Page MenuHomePhabricator

MediaWiki error for deleted Flow board, when clicking 'Show changes'
Closed, DuplicatePublic

Description

MediaWiki gives error, when try to use preview of deleted flow pages.
See:



"Spezial:Wiederherstellen" is german, the english name for this page is "Special:Undelete"

For those, who has sysop access to de.wikipedia.beta.wmflabs.org, the page im undeleting there is http://de.wikipedia.beta.wmflabs.org/wiki/Benutzer_Diskussion:Luke081515


We need to implement BoardContentHandler->createDifferenceEngine. I haven't found a way yet to opt out of diffs being available, so in the meantime we can return some representation, e.g. the JSON or a placeholder.

Message is:

[5bacd45b745a53a372e4150c] /w/index.php?title=Scen_c_4&diff=4724&oldid=4723 MWException from line 804 of /vagrant/mediawiki/includes/diff/DifferenceEngine.php: Diff not implemented for Flow\Content\BoardContent; override generateContentDiffBody to fix this.

Backtrace:

#0 /vagrant/mediawiki/includes/diff/DifferenceEngine.php(747): DifferenceEngine->generateContentDiffBody(Flow\Content\BoardContent, WikitextContent)
#1 /vagrant/mediawiki/includes/diff/DifferenceEngine.php(681): DifferenceEngine->getDiffBody()
#2 /vagrant/mediawiki/includes/diff/DifferenceEngine.php(651): DifferenceEngine->getDiff(string, string, string)
#3 /vagrant/mediawiki/includes/diff/DifferenceEngine.php(454): DifferenceEngine->showDiff(string, string, string)
#4 /vagrant/mediawiki/includes/page/Article.php(787): DifferenceEngine->showDiffPage(boolean)
#5 /vagrant/mediawiki/includes/page/Article.php(498): Article->showDiffPage()
#6 /vagrant/mediawiki/includes/actions/ViewAction.php(44): Article->view()
#7 /vagrant/mediawiki/includes/MediaWiki.php(504): ViewAction->show()
#8 /vagrant/mediawiki/includes/MediaWiki.php(288): MediaWiki->performAction(Article, Title)
#9 /vagrant/mediawiki/includes/MediaWiki.php(746): MediaWiki->performRequest()
#10 /vagrant/mediawiki/includes/MediaWiki.php(520): MediaWiki->main()
#11 /vagrant/mediawiki/index.php(43): MediaWiki->run()
#12 /var/www/w/index.php(5): require(string)
#13 {main}

See also T110696: Can no longer view deleted board in Special:Undelete.

Event Timeline

Luke081515 raised the priority of this task from to Needs Triage.
Luke081515 updated the task description. (Show Details)
Luke081515 added a subscriber: Luke081515.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 28 2015, 2:19 PM
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptAug 28 2015, 2:19 PM
Mattflaschen-WMF renamed this task from MediaWiki error after preview of deleted flow page to MediaWiki error for deleted Flow board, when clicking 'Show changes'.Aug 28 2015, 4:27 PM
Mattflaschen-WMF set Security to None.
Mattflaschen-WMF removed a project: Regression.
DannyH triaged this task as Normal priority.Aug 31 2015, 5:21 PM
DannyH added a subscriber: DannyH.
DannyH removed a subscriber: DannyH.Oct 5 2015, 10:53 PM
Restricted Application added a project: Growth-Team. · View Herald TranscriptSep 12 2018, 2:28 AM
Restricted Application removed a subscriber: Liuxinyu970226. · View Herald Transcript