Page MenuHomePhabricator

Move mobile.abusefilter to AbuseFilter extension.
Open, LowPublic

Description

This code ideologically should not live in MobileFrontend. It should live in the AbuseFilter extension.
To make this transition it's likely a spike will be needed to determine the technology choices we'll need to make.

Event Timeline

Jdlrobson claimed this task.
Jdlrobson raised the priority of this task from to Low.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added subscribers: Jhernandez, Aklapper, Glaisher and 12 others.
Restricted Application added a subscriber: Luke081515. · View Herald TranscriptAug 28 2015, 9:09 PM
matmarex removed a subscriber: matmarex.Aug 31 2015, 5:56 PM
Jdlrobson moved this task from Backlog to Tasks on the MobileFrontend board.Nov 4 2015, 5:16 PM
Jdlrobson moved this task from Tasks to Tech debt on the MobileFrontend board.Feb 18 2016, 6:43 PM

The task needs more information about the bigger plan and the reasoning to use OOJS-UI.

What does mobile.abusefilter do exactly? Does it do anything besides displaying a warning to the user? I suspect that OOJS UI might be overkill for this.

The issue is the code should not live in MobileFrontend. It should live in the AbuseFilter extension.

Oojs ui is currently the only accepted way to build frontend code without adding a new library. It may be a little heavy weight yes.

What does mobile.abusefilter do exactly? Does it do anything besides displaying a warning to the user? I suspect that OOJS UI might be overkill for this.

It first shows a message at the top of the editor overlay with a link to see more info in another overlay (this time, the Abuse Filter overlay). And yes, OOJS-UI doesn't seem to be needed here. In fact, we can even remove the module and replace its functionality with a toast in MF. We may have to adjust the toast code to allow clicking of links as there maybe links to the filter that blocked the action.

jhobs added subscribers: Nirzar, jhobs.

@Jdlrobson can you flesh out a description for this task? Right now it is unclear if moving this code out of MobileFrontend is worth the hit of requiring OOjs-UI. The best course of action may end up being a new design for this action flow, as @bmansurov suggested.
cc @Nirzar

Jdlrobson renamed this task from Rewrite mobile.abusefilter in OOJS UI and upstream to AbuseFilter extension. to Move mobile.abusefilter to AbuseFilter extension..Dec 1 2016, 10:00 PM
Jdlrobson updated the task description. (Show Details)

I've fleshed it out as best I can and tried to keep it as general as possible as I don't have the answer for how we do this. If we want to do that we'll need to invest some time in a spike.