Page MenuHomePhabricator

insource quoted phrase search recently broke
Closed, DuplicatePublic

Description

Some time in the past week, quoted phrase insource searches stopped working. Typing

insource:"could of"

in the search box should return a list of articles with the phrase "could of" in the source, and it used to. Now it returns a list of articles with "could" and "of" in the source, just like

insource:could insource:of

Event Timeline

Giraffedata raised the priority of this task from to Needs Triage.
Giraffedata updated the task description. (Show Details)
Giraffedata added a project: MediaWiki-General.
Giraffedata added a subscriber: Giraffedata.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2015, 2:37 AM
Krenair set Security to None.
Restricted Application added a project: Discovery. · View Herald TranscriptAug 31 2015, 2:39 AM
Cpiral added a subscriber: Cpiral.Sep 3 2015, 5:32 PM

See T111293. It's a feature.

I don't know how tongue-in-cheek "it's a feature" was meant, but I don't find anything in T111293 that suggests someone thinks this was a positive change. It's more likely just a simple programming error, of a fairly common type: the system passes the search string through some interface in which quotation marks mean something, with the effect that they are effectively stripped out of the search string before they reach the thing that actually does the searching.

The comments do, however, suggest a workaround: embedding additional quotation marks within the search string makes a pair of them survive so the effect is what was intended. Example: insource:"\"could of\"" .

Change 236544 had a related patch set uploaded (by Thiemo Mättig (WMDE)):
Fix incategory, insource and intitle with double quoted values

https://gerrit.wikimedia.org/r/236544

Cpiral updated the task description. (Show Details)Sep 8 2015, 11:10 PM

Change 236544 merged by jenkins-bot:
Fix incategory, insource and intitle with double quoted values

https://gerrit.wikimedia.org/r/236544

Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptDec 31 2015, 5:08 AM