Page MenuHomePhabricator

Review i18n messages for extension
Closed, ResolvedPublic

Description

After T109510: Finalize i18n messages for Extension:SmiteSpam, the messages need to be reviewed once by someone familiar with i18n message practices before T109509: Re-enable translation for Extension:SmiteSpam can be done.

Event Timeline

polybuildr raised the priority of this task from to Needs Triage.
polybuildr updated the task description. (Show Details)
polybuildr subscribed.
polybuildr renamed this task from Review i81n messages for extension to Review i18n messages for extension.Aug 31 2015, 7:33 PM
polybuildr set Security to None.

To clarify, by review the messages, I don't mean check the English used, but rather, usage of features such as parameters, plural support, etc. The reason the T109510: Finalize i18n messages for Extension:SmiteSpam was required was because of bad usage of such features. (I was connecting two messages using a comma inside PHP instead of using parameters) There's a very good chance that some updates need to be made.

Feel free to decline if this task does not make sense.

i18n review:

  • remove . from end of description text in "smitespam-desc" for consistency
  • GENDER support needed for
    • "smitespam-created-by"
    • "smitespam-already-trusted"
    • "smitespam-trusted-user-message"
    • "smitespam-userdoesnotexist"
      • For the last 3 please use "$1" instead of '$1' for consistency
    • "smitespam-blocked-user-success-msg"
    • "smitespam-blocked-user-failure-msg"
    • "smitespam-trusted-user-success-msg"
    • "smitespam-trusted-user-failure-msg"
  • In message documentation the variables are not explained
  • In message documentation I miss a hint what "Smite" means. Is it a proper noun and therefore untranslatable or should it be translated?

Change 235607 had a related patch set uploaded (by Polybuildr):
Update i18n messages

https://gerrit.wikimedia.org/r/235607

@Raymond, thanks a lot for that review!

Could you please take a look at the linked patch and check whether the updates have been correctly? Also +2 it if things seem okay to you.

Change 235607 merged by jenkins-bot:
Update i18n messages

https://gerrit.wikimedia.org/r/235607

polybuildr mentioned this in Unknown Object (Diffusion Commit).Sep 6 2015, 6:52 AM

@Bawolff, thanks a lot for the final review!

I'm leaving this task unresolved so that someone very familiar with I18n / translatewiki.net can check if they want and mark it resolved.

Raymond claimed this task.

All fine now.

Change 236410 had a related patch set uploaded (by Polybuildr):
Re-enable translation for Extension:SmiteSpam

https://gerrit.wikimedia.org/r/236410

Change 236410 merged by jenkins-bot:
Re-enable translation for Extension:SmiteSpam

https://gerrit.wikimedia.org/r/236410