After T109510: Finalize i18n messages for Extension:SmiteSpam, the messages need to be reviewed once by someone familiar with i18n message practices before T109509: Re-enable translation for Extension:SmiteSpam can be done.
Description
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Update i18n messages | mediawiki/extensions/SmiteSpam | master | +19 -19 | |
| Re-enable translation for Extension:SmiteSpam | translatewiki | master | +2 -3 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | polybuildr | T109509 Re-enable translation for Extension:SmiteSpam | |||
| Resolved | Raymond | T110935 Review i18n messages for extension |
Event Timeline
To clarify, by review the messages, I don't mean check the English used, but rather, usage of features such as parameters, plural support, etc. The reason the T109510: Finalize i18n messages for Extension:SmiteSpam was required was because of bad usage of such features. (I was connecting two messages using a comma inside PHP instead of using parameters) There's a very good chance that some updates need to be made.
Feel free to decline if this task does not make sense.
i18n review:
- remove . from end of description text in "smitespam-desc" for consistency
- GENDER support needed for
- "smitespam-created-by"
- "smitespam-already-trusted"
- "smitespam-trusted-user-message"
- "smitespam-userdoesnotexist"
- For the last 3 please use "$1" instead of '$1' for consistency
- "smitespam-blocked-user-success-msg"
- "smitespam-blocked-user-failure-msg"
- "smitespam-trusted-user-success-msg"
- "smitespam-trusted-user-failure-msg"
- In message documentation the variables are not explained
- In message documentation I miss a hint what "Smite" means. Is it a proper noun and therefore untranslatable or should it be translated?
@Raymond, thanks a lot for that review!
Could you please take a look at the linked patch and check whether the updates have been correctly? Also +2 it if things seem okay to you.
@Bawolff, thanks a lot for the final review!
I'm leaving this task unresolved so that someone very familiar with I18n / translatewiki.net can check if they want and mark it resolved.
Change 236410 had a related patch set uploaded (by Polybuildr):
Re-enable translation for Extension:SmiteSpam