Maniphest T110960

getConfiguration.php can not export null variables
Closed, ResolvedPublic
Actions

Description

getConfiguration.php script can export various settings, it is also used to import configurations in SiteConfiguration.php. However, due to a bug in isAllowedVariable() function, it allows only values which are arrays or is_scalar(). Unfortunately, is_scalar(NULL) is false, so it produces an error if any config variable is set to null.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+1 -1	Allow to export null values

Customize query in gerrit

Related Objects

Mentioned In: rMW62a6c0b5d1c5: Allow to export null values

Event Timeline

Smalyshev created this task.Aug 31 2015, 10:43 PM

Smalyshev raised the priority of this task from to Needs Triage.

Smalyshev updated the task description. (Show Details)

Smalyshev added projects: MediaWiki-API, MediaWiki-Maintenance-system.

Smalyshev added subscribers: Smalyshev, EBernhardson.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 31 2015, 10:43 PM

Change 235143 had a related patch set uploaded (by Smalyshev):
Allow to export null values

https://gerrit.wikimedia.org/r/235143

gerritbot added a project: Patch-For-Review.Aug 31 2015, 10:46 PM

Change 235143 merged by jenkins-bot:
Allow to export null values

https://gerrit.wikimedia.org/r/235143

Diffusion mentioned this in rMW62a6c0b5d1c5: Allow to export null values.Aug 31 2015, 11:02 PM

Smalyshev closed this task as Resolved.Aug 31 2015, 11:02 PM

Smalyshev claimed this task.

Forrestbot added projects: WMF-deploy-2015-09-01_(1.26wmf21), MW-1.26-release.Sep 1 2015, 12:00 AM

Legoktm edited projects, added MediaWiki-Configuration; removed MediaWiki-API.Sep 1 2015, 12:13 AM

Legoktm set Security to None.