Page MenuHomePhabricator

Blueprint assumes personal_urls[0] contains username
Closed, ResolvedPublic

Description

Blueprint shows text of the first item of the personal_urls in its navbar-right using

{{! HACK: personal_urls.0.text not working }}
{{#each personal_urls}}
    {{#if @first}}
        {{text}}
    {{/if}}
{{/each}}
{{! /HACK }}

I think this used to the username, but on LSG site these days the first is pt-uls (the Universal Language Selector, text is "English"), not pt-userpage.

Note @first doesn't work with core's "mustache-only" version of PHP templating.

The fix is to add server-side logic to provide the necessary piece of data, same as for the sidebar.

Related Objects

StatusAssignedTask
Resolved Spage
Resolved Spage
Resolved Spage
Resolvedori
DeclinedNone
ResolvedNone
DeclinedNone
ResolvedAnomie
DeclinedNone
OpenNone
OpenNone
Resolved Spage
DeclinedNone
Resolvedjeropbrenda
OpenNone
DeclinedQgil
Resolved Spage
ResolvedQgil
ResolvedQgil
ResolvedQgil
Resolved Spage
Resolved Spage
Resolved Spage
DeclinedNone
DeclinedNone
Resolved Spage
Resolved Spage
DeclinedNone
DeclinedNone
Resolved Spage
ResolvedNone

Event Timeline

Spage created this task.Sep 1 2015, 3:34 AM
Spage raised the priority of this task from to Normal.
Spage updated the task description. (Show Details)
Spage added a project: Blueprint.
Spage added a subscriber: Spage.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2015, 3:34 AM
Spage updated the task description. (Show Details)Sep 1 2015, 5:38 AM
Spage set Security to None.

Change 223165 had a related patch set uploaded (by Spage):
Switch to core's server-side HTML templating

https://gerrit.wikimedia.org/r/223165

Change 223165 merged by VolkerE:
Switch to core's server-side HTML templating

https://gerrit.wikimedia.org/r/223165

Volker_E closed this task as Resolved.Oct 15 2015, 1:34 AM
Volker_E moved this task from Needs Review / Feedback to Done on the Blueprint board.
Volker_E removed a project: Patch-For-Review.