Page MenuHomePhabricator

[Regression wmf21] Cancel button does not work in inspectors for extensions
Closed, ResolvedPublic1 Story Points

Description

Steps to reproduce:

  1. Open a page containing a maths formula.
  2. Select the formula and click 'Edit' in the context menu. Change the formula (alternatively, switch to inline or block display).
  3. Decide that you made a mistake. Click 'Cancel'.

Result:

Your changes are preserved anyway. Pressing 'Cancel' appears to be functionally identical to pressing 'Done'.

Expected outcome:

Your changes would actually be cancelled. (What exactly is the Cancel button supposed to do, if not cancel your changes?)

Event Timeline

Whatamidoing-WMF raised the priority of this task from to Normal.
Whatamidoing-WMF updated the task description. (Show Details)
Whatamidoing-WMF added a subscriber: Whatamidoing-WMF.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2015, 6:15 AM
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Looks like we have the same issue with SyntaxHighlight

And I'm guessing maybe wikihiero as well?

And galleries...

Change 235389 had a related patch set uploaded (by Alex Monk):
Fix cancelling of extension inspectors

https://gerrit.wikimedia.org/r/235389

Krenair renamed this task from Cancel button does not work in editing tool for mathematical formulae to Cancel button does not work in inspectors for extensions.Sep 2 2015, 1:33 AM
Krenair claimed this task.
Krenair removed a project: Math.

Change 235389 merged by jenkins-bot:
Fix cancelling of extension inspectors

https://gerrit.wikimedia.org/r/235389

Krenair closed this task as Resolved.Sep 2 2015, 2:10 PM
Jdforrester-WMF renamed this task from Cancel button does not work in inspectors for extensions to [Regression wmf21] Cancel button does not work in inspectors for extensions.Sep 2 2015, 5:08 PM

Change 235511 had a related patch set uploaded (by Jforrester):
Fix cancelling of extension inspectors

https://gerrit.wikimedia.org/r/235511

Change 235511 merged by jenkins-bot:
Fix cancelling of extension inspectors

https://gerrit.wikimedia.org/r/235511