[Regression wmf21] Cancel button does not work in inspectors for extensions
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

Steps to reproduce:

Open a page containing a maths formula.
Select the formula and click 'Edit' in the context menu. Change the formula (alternatively, switch to inline or block display).
Decide that you made a mistake. Click 'Cancel'.

Result:

Your changes are preserved anyway. Pressing 'Cancel' appears to be functionally identical to pressing 'Done'.

Expected outcome:

Your changes would actually be cancelled. (What exactly is the Cancel button supposed to do, if not cancel your changes?)

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/VisualEditor	wmf/1.26wmf21	+11 -6	Fix cancelling of extension inspectors
	mediawiki/extensions/VisualEditor	master	+11 -6	Fix cancelling of extension inspectors

Customize query in gerrit

Related Objects

Mentioned In: rEVED84e28115b7d6: Fix cancelling of extension inspectors
rEVEDa02d8573b442: Fix cancelling of extension inspectors

Event Timeline

Whatamidoing-WMF created this task.Sep 1 2015, 6:15 AM

Whatamidoing-WMF raised the priority of this task from to Medium.

Whatamidoing-WMF updated the task description. (Show Details)

Whatamidoing-WMF added projects: VisualEditor, VisualEditor-EditingTools.

Whatamidoing-WMF added a subscriber: Whatamidoing-WMF.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2015, 6:15 AM

Jdforrester-WMF added a project: Math.Sep 1 2015, 7:04 PM

Jdforrester-WMF set Security to None.

Jdforrester-WMF edited a custom field.

Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.

Krenair added a subscriber: Krenair.Sep 2 2015, 12:53 AM

Looks like we have the same issue with SyntaxHighlight

And I'm guessing maybe wikihiero as well?

And galleries...

Change 235389 had a related patch set uploaded (by Alex Monk):
Fix cancelling of extension inspectors

https://gerrit.wikimedia.org/r/235389

gerritbot added a project: Patch-For-Review.Sep 2 2015, 1:33 AM

Krenair renamed this task from Cancel button does not work in editing tool for mathematical formulae to Cancel button does not work in inspectors for extensions.Sep 2 2015, 1:33 AM

Krenair claimed this task.

Krenair removed a project: Math.

Change 235389 merged by jenkins-bot:
Fix cancelling of extension inspectors

https://gerrit.wikimedia.org/r/235389

Krenair mentioned this in rEVEDa02d8573b442: Fix cancelling of extension inspectors.Sep 2 2015, 11:51 AM

Forrestbot added a project: WMF-deploy-2015-09-08_(1.26wmf22).Sep 2 2015, 12:00 PM

Krenair closed this task as Resolved.Sep 2 2015, 2:10 PM

Jdforrester-WMF renamed this task from Cancel button does not work in inspectors for extensions to [Regression wmf21] Cancel button does not work in inspectors for extensions.Sep 2 2015, 5:08 PM

Change 235511 had a related patch set uploaded (by Jforrester):
Fix cancelling of extension inspectors

https://gerrit.wikimedia.org/r/235511

Change 235511 merged by jenkins-bot:
Fix cancelling of extension inspectors

https://gerrit.wikimedia.org/r/235511

Jdforrester-WMF mentioned this in rEVED84e28115b7d6: Fix cancelling of extension inspectors.Sep 2 2015, 5:25 PM

Forrestbot added a project: WMF-deploy-2015-09-01_(1.26wmf21).Sep 2 2015, 6:00 PM

Jdforrester-WMF removed a project: Patch-For-Review.Sep 8 2015, 12:59 AM

Ryasmeen added a project: Verified-in-Phase0.Sep 8 2015, 10:38 PM