Page MenuHomePhabricator
Create Task
Maniphest T110996

Don't put statement diffs into wb_changes table
Closed, ResolvedPublic
Actions

Description

I don't think we need the full diff for dispatching purposes, nor for use in the client.

Details

SubjectRepoBranchLines +/-
Don't include statements diff in wb_changesmediawiki/extensions/Wikibasewmf/1.26wmf20+33 -0
Don't include statements diff in wb_changesmediawiki/extensions/Wikibasemaster+33 -0
Customize query in gerrit

Related Objects

Event Timeline

aude created this task.Sep 1 2015, 6:30 AM
aude raised the priority of this task from to Needs Triage.
aude updated the task description. (Show Details)
aude subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2015, 6:30 AM
aude added a project: Wikidata.Sep 1 2015, 6:31 AM
aude set Security to None.
aude triaged this task as High priority.Sep 1 2015, 8:09 AM
aude added a comment.Sep 1 2015, 8:31 AM

AffectedPagesFinder in the client uses the label diff, so we need to keep putting it in wb_changes for now. but think we can safely discard the statements part of the diff here.

aude renamed this task from Put only the site link diff into wb_changes table to Don't put statement diffs into wb_changes table.Sep 1 2015, 9:41 AM
Lydia_Pintscher added a project: Wikidata-Sprint-2015-08-18.Sep 1 2015, 9:42 AM
Lydia_Pintscher moved this task from Backlog to Doing on the Wikidata-Sprint-2015-08-18 board.
Lydia_Pintscher subscribed.
• Jonas subscribed.Sep 1 2015, 10:37 AM

If this is in doing then somebody should be assigned to it

Lydia_Pintscher assigned this task to aude.Sep 1 2015, 10:40 AM
aude added a comment.Sep 1 2015, 11:00 AM

https://gerrit.wikimedia.org/r/#/c/235213/

aude added a project: Patch-For-Review.Sep 1 2015, 11:00 AM
Lydia_Pintscher moved this task from incoming to in progress on the Wikidata board.Sep 1 2015, 11:28 AM
Tobi_WMDE_SW moved this task from Doing to Review on the Wikidata-Sprint-2015-08-18 board.Sep 1 2015, 12:43 PM
Tobi_WMDE_SW added a project: Wikidata-Sprint-2015-09-01.Sep 1 2015, 12:46 PM
Tobi_WMDE_SW moved this task from Backlog to Review on the Wikidata-Sprint-2015-09-01 board.
aude mentioned this in T111056: [Task] Replace ChangesTable orm abstraction with ChangeStore and ChangeLookup.Sep 1 2015, 3:07 PM
gerritbot subscribed.Sep 1 2015, 3:11 PM

Change 235213 merged by jenkins-bot:
Don't include statements diff in wb_changes

https://gerrit.wikimedia.org/r/235213

aude mentioned this in rEWBA3160ff902fa0: Don't include statements diff in wb_changes.Sep 1 2015, 3:11 PM
Diffusion mentioned this in rMEXTcc5077922239: Updated mediawiki/extensions Project: mediawiki/extensions/Wikibase….Sep 1 2015, 3:11 PM
gerritbot added a comment.Sep 1 2015, 4:17 PM

Change 235262 had a related patch set uploaded (by Aude):
Don't include statements diff in wb_changes

https://gerrit.wikimedia.org/r/235262

gerritbot added a comment.Sep 1 2015, 4:32 PM

Change 235262 merged by jenkins-bot:
Don't include statements diff in wb_changes

https://gerrit.wikimedia.org/r/235262

aude mentioned this in rEWBAfd1f82818ea4: Don't include statements diff in wb_changes.Sep 1 2015, 4:32 PM
aude closed this task as Resolved.Sep 2 2015, 4:48 AM
aude removed a project: Patch-For-Review.
aude moved this task from Review to Done on the Wikidata-Sprint-2015-09-01 board.
aude mentioned this in T109088: [Task] Profiling and investigate how to improve performance of change dispatcher.Sep 2 2015, 10:23 AM
Lucas_Werkmeister_WMDE mentioned this in T163465: WikibaseChangeNotification change has no statement, description and alias diffs.Apr 20 2017, 4:58 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL