Page MenuHomePhabricator

Remove $wgPreloadJavaScriptMwUtil
Closed, ResolvedPublic

Event Timeline

He7d3r raised the priority of this task from to Needs Triage.
He7d3r updated the task description. (Show Details)
He7d3r added a subscriber: He7d3r.

There is nothing to avoid here, it's not actually being loaded on top

The position attribute only applies to when a modules is loaded by the page controller (e.g. addModules). When wgPreloadJavaScriptMwUtil is false (which it is for Wikimedia) mediawiki.util will not be added to the page. As such, it will not be in any position (not top, not bottom).

Of course, if a different module (which has position=top) is loaded that depends on "mediawiki.util", then it and its dependencies will be loaded from the top. But that will happen irregardless of its position attribute.

Rephrasing bug to focus just on $wgPreloadJavaScriptMwUtil.

Krinkle renamed this task from Deprecate $wgPreloadJavaScriptMwUtil and not load the "mediawiki.util" module from "top" position to Remove $wgPreloadJavaScriptMwUtil and $wgPreloadJavaScriptMwUtil.Sep 1 2015, 5:59 PM
Krinkle triaged this task as Low priority.
Krinkle added a project: MW-1.27-release.
Krinkle set Security to None.

Note that $wgIncludeLegacyJavaScript and $wgPreloadJavaScriptMwUtil have been officially marked deprecated as of 0ac4f99804 (to be released in MediaWiki 1.26).

I propose we remove them in MediaWiki 1.27 (expected to be released in May 2016; Wikimedia 1.27alpha to start in November/December 2015).

matmarex renamed this task from Remove $wgPreloadJavaScriptMwUtil and $wgPreloadJavaScriptMwUtil to Remove $wgIncludeLegacyJavaScript and $wgPreloadJavaScriptMwUtil.Sep 1 2015, 8:16 PM
matmarex added a subscriber: matmarex.

Change 277475 had a related patch set uploaded (by Jforrester):
[WIP] Drop deprecated $wgIncludeLegacyJavaScript and $wgPreloadJavaScriptMwUtil

https://gerrit.wikimedia.org/r/277475

I see this has been tagged for inclusion in Tech News. How would you phrase a simple explanation of this in a sentence or two?

Change 277738 had a related patch set uploaded (by Jforrester):
Drop deprecated $wgPreloadJavaScriptMwUtil

https://gerrit.wikimedia.org/r/277738

Does the removal of $wgPreloadJavaScriptMwUtil in a default configuration anything noticeable (other than internal code clean-up)? wikibits.js has a dependency on mw.util, so as long as wikibits.js is preloaded, mw.util will be preloaded, too, whether or not $wgPreloadJavaScriptMwUtil is true, false, or not existent.

Change 277738 merged by jenkins-bot:
Drop deprecated $wgPreloadJavaScriptMwUtil

https://gerrit.wikimedia.org/r/277738

Jdforrester-WMF renamed this task from Remove $wgIncludeLegacyJavaScript and $wgPreloadJavaScriptMwUtil to Remove $wgPreloadJavaScriptMwUtil.Mar 24 2016, 8:50 PM
Jdforrester-WMF closed this task as Resolved.
Jdforrester-WMF claimed this task.

Does the removal of $wgPreloadJavaScriptMwUtil in a default configuration anything noticeable (other than internal code clean-up)? wikibits.js has a dependency on mw.util, so as long as wikibits.js is preloaded, mw.util will be preloaded, too, whether or not $wgPreloadJavaScriptMwUtil is true, false, or not existent.

Correct. However, note that $wgIncludeLegacyJavaScript is now false by default – T35836: Set $wgIncludeLegacyJavaScript = false by default.

I see this has been tagged for inclusion in Tech News. How would you phrase a simple explanation of this in a sentence or two?

I've moved the user-notice tag (for Wikimedia wiki's Tech News) to T35836.