Page MenuHomePhabricator

Check if IE hacks are still required in Edge
Closed, ResolvedPublic8 Estimated Story Points

Description

  1. From ve.ce.Surface.prototype.onDocumentMouseDown
// HACK: do not do triple click handling in IE, because their click counting is broken
if ( e.originalEvent.detail >= 3 && !ve.init.platform.constructor.static.isInternetExplorer() ) {

We also add the CSS class 've-init-target-ie' to the target which triggers the following:

  1. ve.ce.LanguageAnnotation.css, added in https://gerrit.wikimedia.org/r/#/c/155810
/* Don't apply a background color to language annotations, otherwise the
   text disappears if the span has dir="rtl" */
.ve-init-target-ie .ve-ce-languageAnnotation {
	background: none;
}
  1. ve.ce.FocusableNode.css, added in https://gerrit.wikimedia.org/r/#/c/144104, the same hack occurs in ve.ce.Surface.css and ve.ui.FindAndReplaceDialog.css
/* Set opacity directly on the highlights, rather than their containers,
   otherwise the opacity isn't applied at all */
.ve-init-target-ie .ve-ce-surface-highlights-focused .ve-ce-focusableNode-highlight {
	opacity: 0.5;
}

.ve-init-target-ie .ve-ce-surface-highlights-blurred .ve-ce-focusableNode-highlight {
	opacity: 0.15;
}
  1. in ve.ce.Surface.css, added in https://gerrit.wikimedia.org/r/#/c/200486/
/* Prevent IE from wrapping link text in <u> and <font color> tags */
.ve-init-target-ie .ve-ce-surface-paste a {
	text-decoration: underline !important;
	color: #0066cc;
}
  1. In MW, ve.ce.MWReferenceNode.css, added in https://gerrit.wikimedia.org/r/144104
/* In IE, force hasLayout so the <sup>'s box gets measured correctly */
.ve-init-target-ie .ve-ce-mwReferenceNode {
	display: inline-block;
}
  1. ve.init.mw.Target.css, added in https://gerrit.wikimedia.org/r/144104
/* Undo overflow: hidden; from MW CSS to work around hasLayout issue */
.ve-init-target-ie .ve-ce-surface h1,
.ve-init-target-ie .ve-ce-surface h2,
.ve-init-target-ie .ve-ce-surface h3,
.ve-init-target-ie .ve-ce-surface h4,
.ve-init-target-ie .ve-ce-surface h5,
.ve-init-target-ie .ve-ce-surface h6 {
	overflow: visible;
}

Event Timeline

Esanders raised the priority of this task from to Needs Triage.
Esanders updated the task description. (Show Details)
Esanders added subscribers: Esanders, Catrope.
Jdforrester-WMF set Security to None.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.
  1. Confirmed the triple-click bug is fixed in Edge: http://jsfiddle.net/jo3zf3xL/

Fwiw.... You can access a "secret page" of additional features by typing about:flags in Edge's address bar.

It contains many interesting features that, when enabled "correctly", should address some of the old IE quirks still being questioned. See a GoogleBooks grab of some of the available settings here.


I wish more Edge folks knew about it - I can't figure out a way to make a sticky note saying/discussing as much on the Edge Project page - ideas?

Change 294327 had a related patch set uploaded (by Esanders):
Create separate CSS hack class for Edge

https://gerrit.wikimedia.org/r/294327

Change 294327 merged by jenkins-bot:
Create separate CSS hack class for Edge

https://gerrit.wikimedia.org/r/294327