Page MenuHomePhabricator

Parsoid Batching API: Imageinfo returns strings for dimensions instead of numbers which the mediawiki API does
Closed, ResolvedPublic

Description

See T110692 which is now fixed on the Parsoid end by adding type-conversion code for image into responses. It is worth fixing this in the batching api extension so that it returns numbers instead of strings for image dimensions. See comment in https://gerrit.wikimedia.org/r/#/c/226670/2/includes/ApiParsoidBatch.php

Once done, we should remove the type-conversion code in Parsoid added as part of the fix for T110692

Event Timeline

ssastry created this task.Sep 1 2015, 6:44 PM
ssastry assigned this task to tstarling.
ssastry raised the priority of this task from to Normal.
ssastry updated the task description. (Show Details)
ssastry added projects: Parsing-Team, Parsoid.
ssastry added a subscriber: ssastry.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 1 2015, 6:44 PM

Best to fix it in LocalFile::decodeRow(), I think.

Change 235406 had a related patch set uploaded (by Tim Starling):
In LocalFile normalize integer fields to integers

https://gerrit.wikimedia.org/r/235406

Change 235406 merged by jenkins-bot:
In LocalFile normalize integer fields to integers

https://gerrit.wikimedia.org/r/235406

tstarling closed this task as Resolved.Sep 9 2015, 1:52 AM