Page MenuHomePhabricator

Subscribe client wikis immediately after adding sitelinks
Open, HighPublic

Description

When a sitelink is added to an item, the target wiki should immediately be subscribed to receive change notifications, be adding an entry to the wb_changes_subscription table.

Usually, entries in the wb_changes_subscription table are managed by the client itself. If we however rely on wb_changes_subscription to determine which wiki should receive change notifications, a "chicken and egg" problem presents itself: The client wiki will not be notified about the sitelink being added, because the client wiki was not yet subscribed; so the client wiki will not add a subscription.

To resolve this, the repo should add a subscription to wb_changes_subscription when a sitelink is added (before the corresponding change is written to wb_changes).

NOTE: the repo should not remove the subscription from wb_changes_subscription when a sitelink is removed, since the client wiki may still be using the item by other means, e.g. through Lua.

Event Timeline

daniel raised the priority of this task from to Medium.
daniel updated the task description. (Show Details)
daniel added subscribers: JanZerebecki, Aklapper, daniel.
Lydia_Pintscher renamed this task from Subscribe client wikis immediately after adding sitelinks to [Task] Subscribe client wikis immediately after adding sitelinks.Sep 10 2015, 10:48 AM
Lydia_Pintscher set Security to None.
Lydia_Pintscher lowered the priority of this task from Medium to Low.Apr 23 2017, 6:07 PM
daniel raised the priority of this task from Low to High.Jul 26 2017, 11:25 AM
daniel added a subscriber: hoo.

Bumping prio as per @hoo's comment T110528#3474245.

Lydia_Pintscher renamed this task from [Task] Subscribe client wikis immediately after adding sitelinks to Subscribe client wikis immediately after adding sitelinks.Jan 24 2019, 2:50 PM