Page MenuHomePhabricator
Create Task
Maniphest T111174

Special:UploadWizard needs to notify globally blocked users at the beginning of the process, and provide a standard block message
Closed, ResolvedPublic
Actions

Description

Stewards have been notified of a user trying to upload to Commons using the UploadWizard and they get through the upload and data entry phases to be blocked at the submission of the process.

At that stage the error provided is non-standard / error from the api

something or another ...   (api-error-wikimedia-globalblocking-ipblocked)  ...

pasted_file (948×1 px, 103 KB)

  • Blocking that late in the process is problematic, and really unhelpful, is it possible to identify to the user that they are blocked earlier, eg. prior to an image upload.
  • That we cannot provide a standard block message with the IP blocked is completely unuseful and unhelpful. Can we please fix the call to provide the standard block message.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Check for global blocks in addition to regular ones before showing the wizardmediawiki/extensions/UploadWizardmaster+11 -0
Customize query in gerrit

Related Objects

Event Timeline

Billinghurst created this task.Sep 2 2015, 12:40 PM
Billinghurst raised the priority of this task from to Needs Triage.
Billinghurst updated the task description. (Show Details)
Billinghurst added a project: UploadWizard.
Billinghurst subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptSep 2 2015, 12:40 PM
Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald Transcript
matmarex mentioned this in T105863: Notify user of blocked IP before the upload process starts, not when it completes.Sep 2 2015, 1:55 PM
matmarex merged a task: T105863: Notify user of blocked IP before the upload process starts, not when it completes.Sep 2 2015, 2:35 PM
matmarex added subscribers: matmarex, zhuyifei1999, Matanya and 2 others.
gerritbot subscribed.Sep 2 2015, 6:02 PM

Change 235517 had a related patch set uploaded (by Bartosz Dziewoński):
Check for global blocks in addition to regular ones before showing the wizard

https://gerrit.wikimedia.org/r/235517

gerritbot added a project: Patch-For-Review.Sep 2 2015, 6:02 PM
matmarex added a comment.EditedSep 2 2015, 6:06 PM

I discovered a couple of things while working on this and filed separate bugs:

matmarex updated the task description. (Show Details)Sep 2 2015, 6:07 PM
matmarex set Security to None.
matmarex mentioned this in T111229: Special:Upload does not check for global blocks until the form is submitted.
Billinghurst added a subtask: T43492: [DO NOT USE] Steward, global sysop and SWMT tasks bugs (tracking) [superseded by #Stewards-and-global-tools].Sep 3 2015, 3:02 AM
Glaisher removed a subtask: T43492: [DO NOT USE] Steward, global sysop and SWMT tasks bugs (tracking) [superseded by #Stewards-and-global-tools].Sep 3 2015, 4:41 AM
Glaisher subscribed.
Billinghurst added a comment.Sep 3 2015, 4:44 AM

I added the blocking task purposefully for stewards.

Billinghurst added a subtask: T43492: [DO NOT USE] Steward, global sysop and SWMT tasks bugs (tracking) [superseded by #Stewards-and-global-tools].Sep 3 2015, 4:44 AM
Glaisher added a comment.Sep 3 2015, 4:47 AM

Billinghurst added a blocking task: T43492: Steward, global sysop and SWMT tasks bugs (tracking).

This is wrong. It should be the other way round. I removed it to add it the blocked by list at the other task but it looks like Phabricator is - well - just freezing after submission.

Glaisher removed a subtask: T43492: [DO NOT USE] Steward, global sysop and SWMT tasks bugs (tracking) [superseded by #Stewards-and-global-tools].Sep 3 2015, 4:50 AM
Glaisher added a parent task: T43492: [DO NOT USE] Steward, global sysop and SWMT tasks bugs (tracking) [superseded by #Stewards-and-global-tools].

It finally worked. I don't know why that was happening but it has happened a few times previously also when editing T43492's blocked by list. Maybe because it has lots of blocked by tasks?

Jdforrester-WMF triaged this task as Medium priority.Sep 4 2015, 6:48 PM
Jdforrester-WMF moved this task from Untriaged to Doing on the Multimedia board.Sep 4 2015, 6:57 PM
Jdforrester-WMF assigned this task to matmarex.Sep 8 2015, 2:55 PM
Jdforrester-WMF moved this task from Doing to Needs code review on the Multimedia board.Sep 8 2015, 3:36 PM
gerritbot added a comment.Sep 9 2015, 11:59 PM

Change 235517 merged by jenkins-bot:
Check for global blocks in addition to regular ones before showing the wizard

https://gerrit.wikimedia.org/r/235517

Diffusion mentioned this in rMEXT9ebec9395b26: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Sep 10 2015, 12:00 AM
matmarex mentioned this in rEUWI4de93eebda14: Check for global blocks in addition to regular ones before showing the wizard.Sep 10 2015, 12:02 AM
Jdforrester-WMF closed this task as Resolved.Sep 10 2015, 12:03 AM
Jdforrester-WMF moved this task from Needs code review to Done on the Multimedia board.
ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 10 2015, 10:02 PM
Billinghurst mentioned this in T111228: Blocked users can upload files to stash.Oct 1 2015, 12:58 PM
Trijnstel subscribed.Dec 18 2015, 12:05 PM
Billinghurst unsubscribed.Dec 19 2015, 1:26 PM
MarcoAurelio added a project: Stewards-and-global-tools.Jan 11 2017, 11:28 PM
Denniss unsubscribed.Jan 11 2017, 11:35 PM
MarcoAurelio removed a parent task: T43492: [DO NOT USE] Steward, global sysop and SWMT tasks bugs (tracking) [superseded by #Stewards-and-global-tools].Jan 11 2017, 11:39 PM
MarcoAurelio moved this task from Untriaged to Closed on the Stewards-and-global-tools board.Jan 22 2017, 12:55 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits