Page MenuHomePhabricator

Bug: Survey and beta sign up panels show at the same time in mobile skin
Closed, ResolvedPublic

Description

Don't show the survey when the beta signup form is visible
The beta signup form isn't uniquely identified

Event Timeline

Jdlrobson updated the task description. (Show Details)
Jdlrobson raised the priority of this task from to High.
bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-55-π board.

Change 235717 had a related patch set uploaded (by Bmansurov):
Let other extensions know if beta opt-in panel is inserted in DOM

https://gerrit.wikimedia.org/r/235717

Change 235719 had a related patch set uploaded (by Bmansurov):
Don't show the survey panel when minerva beta opt-in panel is shown

https://gerrit.wikimedia.org/r/235719

phuedx added a comment.Sep 3 2015, 2:49 PM

Merging @bmansurov's patches, which LGTM, might be temporarily blocked on T111369.

Change 235717 merged by jenkins-bot:
Let interested parties know whether the beta opt-in panel is shown

https://gerrit.wikimedia.org/r/235717

Change 235719 merged by jenkins-bot:
Don't show the survey panel when minerva beta opt-in panel is shown

https://gerrit.wikimedia.org/r/235719

Jdlrobson closed this task as Resolved.

Looks good to me.
It would be great to make BetaOptin a type of survey in future so it has equal footing against the others but that might be out of scope for the extension (I imagine we could make it an external survey which leads to a splash page where you can opt in)