Page MenuHomePhabricator
Create Task
Maniphest T111188

Bug: Survey and beta sign up panels show at the same time in mobile skin
Closed, ResolvedPublic
Actions

Description

Don't show the survey when the beta signup form is visible
The beta signup form isn't uniquely identified

Details

SubjectRepoBranchLines +/-
Don't show the survey panel when minerva beta opt-in panel is shownmediawiki/extensions/QuickSurveysdev+66 -50
Let interested parties know whether the beta opt-in panel is shownmediawiki/extensions/MobileFrontendmaster+8 -2
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jdlrobson created this task.Sep 2 2015, 2:50 PM
Jdlrobson raised the priority of this task from to High.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: QuickSurveys, Reading-Web-Sprint-55-π.
Jdlrobson added subscribers: Jdlrobson, • Jhernandez, phuedx, Aklapper.
phuedx added a comment.Sep 2 2015, 4:20 PM

Screen Shot 2015-08-25 at 13.00.39.png (364×1 px, 56 KB)

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-55-π board.Sep 2 2015, 4:37 PM
• bmansurov claimed this task.Sep 3 2015, 11:24 AM
• bmansurov moved this task from To Do to Doing on the Reading-Web-Sprint-55-π board.
gerritbot subscribed.Sep 3 2015, 12:50 PM

Change 235717 had a related patch set uploaded (by Bmansurov):
Let other extensions know if beta opt-in panel is inserted in DOM

https://gerrit.wikimedia.org/r/235717

gerritbot added a project: Patch-For-Review.Sep 3 2015, 12:50 PM
gerritbot added a comment.Sep 3 2015, 12:56 PM

Change 235719 had a related patch set uploaded (by Bmansurov):
Don't show the survey panel when minerva beta opt-in panel is shown

https://gerrit.wikimedia.org/r/235719

• bmansurov moved this task from Doing to Code Review on the Reading-Web-Sprint-55-π board.Sep 3 2015, 12:59 PM
phuedx added a comment.Sep 3 2015, 2:49 PM

Merging @bmansurov's patches, which LGTM, might be temporarily blocked on T111369.

gerritbot added a comment.Sep 3 2015, 5:16 PM

Change 235717 merged by jenkins-bot:
Let interested parties know whether the beta opt-in panel is shown

https://gerrit.wikimedia.org/r/235717

• bmansurov mentioned this in rMEXT5c1099f3e737: Updated mediawiki/extensions Project: mediawiki/extensions/MobileFrontend….Sep 3 2015, 5:16 PM
• bmansurov mentioned this in rEMFR7dd49472e849: Let interested parties know whether the beta opt-in panel is shown.
gerritbot added a comment.Sep 3 2015, 5:26 PM

Change 235719 merged by jenkins-bot:
Don't show the survey panel when minerva beta opt-in panel is shown

https://gerrit.wikimedia.org/r/235719

phuedx moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-55-π board.Sep 3 2015, 5:28 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-08_(1.26wmf22).Sep 3 2015, 6:00 PM
Jdlrobson closed this task as Resolved.Sep 4 2015, 12:03 AM
Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-55-π board.

Looks good to me.
It would be great to make BetaOptin a type of survey in future so it has equal footing against the others but that might be out of scope for the extension (I imagine we could make it an external survey which leads to a splash page where you can opt in)

• bmansurov mentioned this in rEQS5dd6eb413848: Don't show the survey panel when minerva beta opt-in panel is shown.Apr 28 2016, 6:22 AM
• bmansurov mentioned this in rEQS822a0803c017: Don't show the survey panel when minerva beta opt-in panel is shown.
phuedx mentioned this in T218243: QuickSurveys will not show on mobile if the beta optin experiment is not set.Mar 19 2019, 5:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL