Please support links in Change-Id in patches. Like git did please support it here. for example please see https://phabricator.wikimedia.org/rEMEScb17279b82dd1e08ee954b75e12a9fef627f68c7 which Change-Id is not linked.
Description
Description
Revisions and Commits
Revisions and Commits
| rPHEX phabricator-extensions | |||
| rPHEX9e5ae1c08fcb Add GerritChangeIdField custom field | |||
Related Objects
Related Objects
- Mentioned Here
- T89939: Linkify gerrit change-id in diffusion
Event Timeline
Comment Actions
Sorry I made a mistake and said something different I have corrected it now it is to do with Change-Id not linking now.
Comment Actions
The "Change-Id: " is not a clickable link in the example above. So diffusion does not link you to Gerrit.
While on git.wikimedia.org, -> http://git.wikimedia.org/commit/mediawiki%2Fextensions%2FMwEmbedSupport.git/cb17279b82dd1e08ee954b75e12a9fef627f68c7 it is a clickable link that gets you to the Gerrit change
Comment Actions
Gotcha. This request only applies in the current Gerrit+Phabricator world. When we switch to using Differential for code-review whatever work put into this task is no longer used. As such, I'm setting this to lowest priority. Hopefully we can close this as "invalid" in the not too distant future when we retire Gerrit.
Comment Actions
Ok but coulden change-id be linked to gerrit temporarily until we do make that change since diffusion is now the default file viewing since the link was changed from git to phabricator in mediawiki.
Comment Actions
Sure, it can but I'm not going to prioritize it on my team's work and jeopardize the more important work of actually migrating to Differential (which makes this work moot). In other words: no, the (short term) benefit doesn't justify the expenditure.
Comment Actions
I think this has been done. Since https://phabricator.wikimedia.org/rOPUP0840e37a86d4ecba38ee185c5500a0b760d8618a shows in the Change Id the link.
I'm not sure weather we can decline this now.