Page MenuHomePhabricator

We are loading JavaScript for blacklisted browsers
Closed, ResolvedPublic

Description

Either spoof your user agent with "Mozilla/4.0 (compatible; MSIE 6.1; Windows XP; .NET CLR 1.1.4322; .NET CLR 2.0.50727)" or use browser stack IE6.

Expected: No JavaScript expected to run on mobile or desktop
Actual: Mobile loads JS, desktop thows JavaScript errors after attempting to load

Traced back to T39894 (https://gerrit.wikimedia.org/r/#/c/234678/)
Setting to unbreak now as this is breaking browser tests for MobileFrontend and stopping us from merging.

Event Timeline

Jdlrobson created this task.Sep 2 2015, 6:42 PM
Jdlrobson raised the priority of this task from to Unbreak Now!.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 2 2015, 6:42 PM

Change 235529 had a related patch set uploaded (by Jdlrobson):
Revert "resourceloader: Remove global startUp() callback"

https://gerrit.wikimedia.org/r/235529

Change 235529 abandoned by Krinkle:
Revert "resourceloader: Remove global startUp() callback"

Reason:
Obsolete with Ie65427caee4231b4ca97a43.

https://gerrit.wikimedia.org/r/235529

Change 235535 had a related patch set uploaded (by Krinkle):
resourceloader: Ensure startup module returns early for incompatible browsers

https://gerrit.wikimedia.org/r/235535

Krinkle claimed this task.Sep 2 2015, 7:29 PM
Krinkle set Security to None.

Change 235544 had a related patch set uploaded (by Krinkle):
resourceloader: Ensure startup module returns early for incompatible browsers

https://gerrit.wikimedia.org/r/235544

Change 235535 merged by jenkins-bot:
resourceloader: Ensure startup module returns early for incompatible browsers

https://gerrit.wikimedia.org/r/235535

Change 235544 merged by jenkins-bot:
resourceloader: Ensure startup module returns early for incompatible browsers

https://gerrit.wikimedia.org/r/235544

Krinkle closed this task as Resolved.Sep 2 2015, 8:07 PM
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptAug 18 2016, 8:13 PM