Page MenuHomePhabricator
Create Task
Maniphest T111381

Notice: Undefined index: 1 in UploadWizardCampaign.php on line 447
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Spotted in production:

Notice: Undefined index: 1 in /srv/mediawiki/php-1.26wmf21/extensions/UploadWizard/includes/UploadWizardCampaign.php on line 447

Details

SubjectRepoBranchLines +/-
Consider the object reference not being passed in the expected formatmediawiki/extensions/UploadWizardmaster+46 -13
Customize query in gerrit

Related Objects

Event Timeline

• demon created this task.Sep 3 2015, 3:52 PM
• demon raised the priority of this task from to Low.
• demon updated the task description. (Show Details)
• demon added a project: Wikimedia-production-error.
• demon moved this task to Dec2019/1.35.wmf.10+ on the Wikimedia-production-error board.
• demon subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 3 2015, 3:52 PM
• demon added a project: UploadWizard.Sep 3 2015, 3:53 PM
Restricted Application added a project: Multimedia. · View Herald TranscriptSep 3 2015, 3:53 PM
Restricted Application added a subscriber: Steinsplitter. · View Herald Transcript
matmarex assigned this task to kai.nissen.Sep 4 2015, 12:06 PM
matmarex added subscribers: kai.nissen, matmarex.

Apparently a small bug in da6e9ac6:

	private function getButtonHrefByObjectReference( $objRef ) {
/*447*/		list( $wiki, $title ) = explode( '|', $objRef );
		if ( Interwiki::isValidInterwiki( $wiki ) ) {
			return str_replace( '$1', $title, Interwiki::fetch( $wiki )->getURL() );
		}
		return false;
	}

I'm not sure what this code is supposed to do when $objRef (pipe-separated string) has only one value. Should that be ignored, or treated as a title on the current wiki? @kai.nissen?

Restricted Application added a subscriber: Matanya. · View Herald TranscriptSep 4 2015, 12:06 PM
gerritbot subscribed.Sep 4 2015, 2:55 PM

Change 236026 had a related patch set uploaded (by Kai Nissen (WMDE)):
Consider the object reference not being passed in the expected format

https://gerrit.wikimedia.org/r/236026

gerritbot added a project: Patch-For-Review.Sep 4 2015, 2:55 PM
gerritbot added a comment.Sep 4 2015, 3:02 PM

Change 236026 merged by jenkins-bot:
Consider the object reference not being passed in the expected format

https://gerrit.wikimedia.org/r/236026

kai.nissen mentioned this in rMEXTf96d796152be: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Sep 4 2015, 3:02 PM
matmarex closed this task as Resolved.Sep 4 2015, 3:03 PM
kai.nissen mentioned this in rEUWIccc1ce5767b3: Consider the object reference not being passed in the expected format.Sep 4 2015, 3:03 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-08_(1.26wmf22).Sep 4 2015, 4:00 PM
• demon moved this task from Dec2019/1.35.wmf.10+ to Resolved on the Wikimedia-production-error board.Sep 4 2015, 4:53 PM
kai.nissen added projects: TCB-Team (now WMDE-TechWish), TCB-Team-Fundraising-Sprint-2015-09-02.Sep 7 2015, 9:14 AM
kai.nissen set Security to None.
kai.nissen moved this task from Backlog to Done on the TCB-Team-Fundraising-Sprint-2015-09-02 board.
kai.nissen edited a custom field.
WMDE-leszek edited projects, added TCB-Team-Sprint-2015-08-26; removed TCB-Team-Fundraising-Sprint-2015-09-02.Sep 7 2015, 10:02 AM
kai.nissen moved this task from Backlog to Done on the TCB-Team-Sprint-2015-08-26 board.Sep 8 2015, 9:55 AM
Jdforrester-WMF moved this task from Untriaged to Done on the Multimedia board.Sep 11 2015, 6:11 PM
Addshore moved this task from Incoming to Done on the TCB-Team (now WMDE-TechWish) board.Nov 27 2015, 10:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL