Page MenuHomePhabricator

QA: No browser tests covering QuickSurveys in mobile skin
Closed, DeclinedPublic

Description

We should have the following integration tests:

  • A test that asserts that an internal quick survey shows up when the user is in a sample and that the user can go through the workflow.
  • A test that asserts that an internal quick survey does not shows up when the user is not in the sample

I think these are enough since the code between desktop and mobile shouldn't differ too greatly.

For these to work per commit we'll likely to need help from @dduvall to ensure MobileFrontend gets installed for the purpose of the browser tests (but is not an extension dependency)

Event Timeline

Jdlrobson raised the priority of this task from to High.
Jdlrobson updated the task description. (Show Details)
Jdlrobson updated the task description. (Show Details)
Jdlrobson set Security to None.
Jdlrobson updated the task description. (Show Details)Sep 9 2015, 12:39 AM
Jdlrobson lowered the priority of this task from High to Normal.Oct 1 2015, 8:56 PM
Jdlrobson lowered the priority of this task from Normal to Low.Dec 17 2015, 8:27 PM

Differences between desktop and mobile are currently minimal

@Jdlrobson, @Jdrewniak: Is this task a good task for @Ryasmeen to pick up?

Rather than pinging y'all on separate tasks, I'll send an email!

Jdlrobson closed this task as Declined.Oct 16 2018, 9:38 PM

I had a look at this and given the low benefit of adding this and the high cost of getting this setup, I don't think this task would add much (except a higher maintenance burden).

Let's get these ported to Node.js though (T177261)