Page MenuHomePhabricator

App: remove isDisambiguation from PageLead
Closed, DeclinedPublic

Description

(This task is optional. Don't sweat it if you don't agree with it.)

The service doesn't provide the disambiguation property yet, so there is no need to try parse it in the app.

We'll still want to keep this field in PageProperties since that gets populated also by other network responses (the suggestions task). I think in the constructor that is called by PageLead could just set it to false.

Event Timeline

bearND raised the priority of this task from to Low.
bearND updated the task description. (Show Details)
bearND moved this task to Backlog on the Mobile-Content-Service board.
bearND subscribed.

Could you explain what this means? Do you need the service to provide the disambiguation property or is this more to do with the app?

This task is in the wrong columns. This was meant for the Android app, so it should be in the backlog or tech debt columns for the app and tracking for the service. Anyways, looks like we're trying to add isDisambiguation after all (T151241), so it seems counter-productive to remove it in the app.