Maniphest T111544

ContentTranslation source loader doesn't have complete handling for invalid titles
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

The code in ext.cx.source.js says:

title = mw.Title.newFromText( mw.cx.sourceTitle );

if ( title ) {
    mw.cx.sourceTitle = title.getPrefixedText();
}

It looks like the case of invalid title is silently ignored.

Details

	Subject	Repo	Branch	Lines +/-
	Handle invalid title when loading the source	mediawiki/extensions/ContentTranslation	master	+19 -16

Customize query in gerrit

Related Objects

Mentioned In: T115315: ContentTranslation fails with Internal server error if an invalid title is given
Mentioned Here: T115315: ContentTranslation fails with Internal server error if an invalid title is given

Event Timeline

Amire80 created this task.Sep 4 2015, 5:29 PM

Amire80 raised the priority of this task from to Medium.

Amire80 updated the task description. (Show Details)

Amire80 added projects: ContentTranslation, ContentTranslation-Release6.

Amire80 subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2015, 5:29 PM

Amire80 moved this task from Backlog to Tech Debt on the ContentTranslation-Release6 board.Sep 4 2015, 5:30 PM

Amire80 moved this task from Needs Triage to CX6 on the ContentTranslation board.Sep 5 2015, 2:40 PM

Amire80 moved this task from CX6 to CX7 on the ContentTranslation board.Oct 1 2015, 5:52 PM

Change 245583 had a related patch set uploaded (by Amire80):
Handle invalid title when loading the source

https://gerrit.wikimedia.org/r/245583

gerritbot added a project: Patch-For-Review.Oct 12 2015, 7:51 PM

Amire80 claimed this task.Oct 12 2015, 7:52 PM

Amire80 removed a project: ContentTranslation-Release6.

Amire80 set Security to None.

Amire80 added projects: Technical-Debt, Essential-Work, ContentTranslation-Release7.

Amire80 added projects: LE-CX7-Sprint 1, good first task.Oct 13 2015, 8:32 AM

Amire80 mentioned this in T115315: ContentTranslation fails with Internal server error if an invalid title is given.Oct 13 2015, 10:43 AM

See T115315 for a similar issue on the server side.

Amire80 moved this task from Backlog to In review on the LE-CX7-Sprint 1 board.Oct 14 2015, 10:48 AM

Amire80 moved this task from Backlog to High-priority Bugs on the ContentTranslation-Release7 board.Oct 15 2015, 9:51 PM

Change 245583 merged by jenkins-bot:
Handle invalid title when loading the source

https://gerrit.wikimedia.org/r/245583

ReleaseTaggerBot added a project: MW-1.27-release (WMF-deploy-2015-10-27_(1.27.0-wmf.4)).Oct 19 2015, 10:00 AM

Amire80 moved this task from In review to QA on the LE-CX7-Sprint 1 board.Oct 20 2015, 6:55 AM

Amire80 moved this task from QA to Done on the LE-CX7-Sprint 1 board.Oct 21 2015, 6:16 AM

Amire80 closed this task as Resolved.Oct 23 2015, 5:24 PM

Amire80 edited a custom field.Oct 24 2015, 12:47 PM