Page MenuHomePhabricator

MassMessageJob::makeAPIRequest() does not un-register hooks
Open, LowPublic

Description

	protected function makeAPIRequest( array $params ) {
		global $wgHooks, $wgUser, $wgRequest;

		// Add our hook functions to make the MassMessage user IP block-exempt and email confirmed
		// Done here so that it's not unnecessarily called on every page load
		$wgHooks['UserGetRights'][] = 'MassMessageHooks::onUserGetRights';
		$wgHooks['EmailConfirmed'][] = 'MassMessageHooks::onEmailConfirmed';

We don't un-register those hooks anywhere.

Event Timeline

Legoktm raised the priority of this task from to Low.
Legoktm updated the task description. (Show Details)
Legoktm added subscribers: Legoktm, wctaiwan.