extensions/TimedMediaHandler - file permissions trigger debian lintian warnings
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	wpmirrordev
	Sep 7 2015, 11:20 PM

Description

0) Context

DEB packages of mediawiki and many of its extensions, are prepared as part of the WP-MIRROR project.
See https://www.mediawiki.org/wiki/Wp-mirror.

Lintian

During the build process, lintian performs a great number of sanity checks, including seeing if each file has file permissions appropriate to its file type.

When lintian sees a non-executable file with 755 permissions, rather than 644, lintian will throw a warning like:

W: wp-mirror-mediawiki: executable-not-elf-or-script usr/share/wp-mirror-mediawiki/extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscodeJob.php

Files which should have permissions set to 644

extensions/TimedMediaHandler/WebVideoTranscode/WebVideoTranscodeJob.php

Technical details

DEB standards version: 3.9.6
GIT branch: master

Details

	Subject	Repo	Branch	Lines +/-
	chmod 644 WebVideoTranscodeJob.php	mediawiki/extensions/TimedMediaHandler	master	+0 -0

Customize query in gerrit

Related Objects

Mentioned In: rETMH5e1ded3f8231: chmod 644 WebVideoTranscodeJob.php
rMEXT491be3630a6b: Updated mediawiki/extensions Project: mediawiki/extensions/TimedMediaHandler…
Mentioned Here: rETMHa963ee82be1f: Made WebVideoTranscodeJob bail if the work is started already

Event Timeline

wpmirrordev created this task.Sep 7 2015, 11:20 PM

wpmirrordev assigned this task to • brion.

wpmirrordev raised the priority of this task from to Medium.

wpmirrordev updated the task description. (Show Details)

wpmirrordev added projects: TimedMediaHandler, good first task.

wpmirrordev subscribed.

Restricted Application added a project: Multimedia. · View Herald TranscriptSep 7 2015, 11:20 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Restricted Application added a subscriber: Matanya. · View Herald Transcript

Jdforrester-WMF moved this task from Untriaged to Backlog on the Multimedia board.Sep 8 2015, 12:32 AM

@Krenair fixed this in https://gerrit.wikimedia.org/r/#/c/221388/, but this was (accidentally) reverted in https://gerrit.wikimedia.org/r/#/c/226617/1. You can't see that in Gerrit (fail), but in Diffusion (rETMHa963ee82be1f371ba6324c4ad0b68bcbe99e4aca) and GitHub (https://github.com/wikimedia/mediawiki-extensions-TimedMediaHandler/commit/a963ee82be1f371ba6324c4ad0b68bcbe99e4aca) you can. Funny.

In T111745#1616735, @Southparkfan wrote:

You can't see that in Gerrit (fail)

Yeah, it's quite annoying that Gerrit doesn't show mode changes when you alter the file in another way too. We ran into it in wikimedia's mediawiki-config repository today, I only noticed while merging the change on the deployment server.

I wonder if there's an upstream bug for that somewhere.

Change 236809 had a related patch set uploaded (by Southparkfan):
chmod 644 WebVideoTranscodeJob.php

https://gerrit.wikimedia.org/r/236809

gerritbot added a project: Patch-For-Review.Sep 8 2015, 3:46 PM

Change 236809 merged by jenkins-bot:
chmod 644 WebVideoTranscodeJob.php

https://gerrit.wikimedia.org/r/236809

Southparkfan mentioned this in rMEXT491be3630a6b: Updated mediawiki/extensions Project: mediawiki/extensions/TimedMediaHandler….Sep 8 2015, 3:51 PM

Jdforrester-WMF closed this task as Resolved.Sep 8 2015, 3:51 PM

Jdforrester-WMF reassigned this task from • brion to Southparkfan.

Jdforrester-WMF removed a project: Patch-For-Review.

Jdforrester-WMF set Security to None.

Southparkfan mentioned this in rETMH5e1ded3f8231: chmod 644 WebVideoTranscodeJob.php.Sep 8 2015, 3:53 PM