Improve Phabricator link on Wikidata Query Service dashboard
Closed, ResolvedPublic

He7d3r created this task.Sep 8 2015, 3:00 PM
He7d3r updated the task description. (Show Details)
He7d3r raised the priority of this task from to Needs Triage.
He7d3r added a subscriber: He7d3r.
Restricted Application added a project: Wikidata. · View Herald TranscriptSep 8 2015, 3:00 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Lydia_Pintscher moved this task from incoming to monitoring on the Wikidata board.Sep 8 2015, 4:43 PM
Lydia_Pintscher set Security to None.
Lydia_Pintscher added a subscriber: Smalyshev.

@mpopov @Ironholds Patch for you to review, here.

Deskana moved this task from Backlog to Needs review on the Discovery-Analysis (Current work) board.
Deskana renamed this task from Improve Phabricator link on Wikidata Query Service page to Improve Phabricator link on Wikidata Query Service dashboard.
Deskana triaged this task as Normal priority.
Deskana assigned this task to He7d3r.
Deskana moved this task from Needs triage to Analysis on the Discovery board.

Do github patchsets map to gerrit ones easily? I'm not seeing anything on gerrit itself.

mpopov added a comment.Sep 8 2015, 5:09 PM

They do not. Wikimedia repos on GitHub are simple mirrors of Gerrit. To the point where the version on GitHub says that OliverKeyes committed to it but there's no such user. The patch needs to be submitted to Gerrit.

He7d3r added a comment.Sep 8 2015, 6:29 PM
This comment was removed by He7d3r.

Change 236851 had a related patch set uploaded (by He7d3r):
Point the Phabricator link to the Discovery board

https://gerrit.wikimedia.org/r/236851

Change 236851 merged by Bearloga:
Point the Phabricator link to the Discovery board

https://gerrit.wikimedia.org/r/236851

Deskana closed this task as Resolved.Sep 8 2015, 6:37 PM

Thanks @He7d3r!

Out of curiosity, was there some documentation somewhere that pointed you to submit a patch on GitHub rather than via Gerrit? If so, could you tell me where it was so that we can change it?

He7d3r added a comment.Sep 8 2015, 9:33 PM

It is just because I use GitHub to search on WMF all repositories at once (in the case, to find where that text come from). And I was also having trouble with gerrit (https://wikitech.wikimedia.org/w/index.php?diff=176416).

It is just because I use GitHub to search on WMF all repositories at once (in the case, to find where that text come from). And I was also having trouble with gerrit (https://wikitech.wikimedia.org/w/index.php?diff=176416).

Ah, right. Well, thanks again for your contribution. :-)