Page MenuHomePhabricator

Echo flyout icon flashes color change from white to black in MonoBook skin
Closed, ResolvedPublic

Description

The nojs code loads a white icon next to the number, then the JS version loads, and replaces it with a black icon.

Event Timeline

Legoktm created this task.Sep 8 2015, 4:25 PM
Legoktm updated the task description. (Show Details)
Legoktm raised the priority of this task from to Needs Triage.
Legoktm added a project: Notifications.
Legoktm added subscribers: Legoktm, Mooeypoo.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 8 2015, 4:25 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript

MonoBook uses Apex, which doesn't support inverted icons... I'm not sure why it flashes at all, it should always be black there.

If you disable JS, you'll see only the white icon loaded.

Legoktm set Security to None.Sep 8 2015, 5:28 PM
Legoktm added a subscriber: matmarex.

Change 237424 had a related patch set uploaded (by Legoktm):
Only use inverted icons for skins using the MediaWiki OOUI theme

https://gerrit.wikimedia.org/r/237424

Change 237440 had a related patch set uploaded (by Legoktm):
Only use inverted icons for skins using the MediaWiki OOUI theme

https://gerrit.wikimedia.org/r/237440

Change 237424 merged by jenkins-bot:
Only use inverted icons for skins using the MediaWiki OOUI theme

https://gerrit.wikimedia.org/r/237424

Change 237440 merged by jenkins-bot:
Only use inverted icons for skins using the MediaWiki OOUI theme

https://gerrit.wikimedia.org/r/237440

Legoktm closed this task as Resolved.Sep 10 2015, 6:25 PM
Legoktm claimed this task.