Page MenuHomePhabricator
Create Task
Maniphest T111825

Weird spacing around links in Echo flyout in Modern skin
Closed, ResolvedPublic
Actions

Description

How it used to look in Modern:

modern-old.png (373×659 px, 43 KB)

What it looks like now:

modern-new.png (417×589 px, 37 KB)

MonoBook, for comparison:

monobook-new.png (395×637 px, 32 KB)

Details

SubjectRepoBranchLines +/-
Override padding for links in personal tools in Modern skinmediawiki/extensions/Echowmf/1.26wmf22+5 -0
Override padding for links in personal tools in Modern skinmediawiki/extensions/Echomaster+5 -0
Customize query in gerrit

Related Objects

Event Timeline

Legoktm created this task.Sep 8 2015, 4:55 PM
Legoktm raised the priority of this task from to Needs Triage.
Legoktm updated the task description. (Show Details)
Legoktm added projects: Collaboration-Team-Triage, Notifications.
Legoktm added subscribers: Aklapper, Mooeypoo, Legoktm.
Legoktm added a comment.Sep 8 2015, 5:18 PM

This has to do with a padding rule applying to #p-personal li a: https://phabricator.wikimedia.org/diffusion/SMOD/browse/master/resources/main.css;9a1020e912eefef6777a6615befdfb1eacd576b8$92

Legoktm mentioned this in T108190: Split notifications into Alerts and Messages.Sep 10 2015, 8:04 PM
gerritbot subscribed.Sep 10 2015, 8:41 PM

Change 237495 had a related patch set uploaded (by Legoktm):
Override padding for links in personal tools in Modern skin

https://gerrit.wikimedia.org/r/237495

gerritbot added a project: Patch-For-Review.Sep 10 2015, 8:41 PM
Luke081515 subscribed.Sep 10 2015, 8:42 PM
gerritbot added a comment.Sep 10 2015, 10:56 PM

Change 237495 merged by jenkins-bot:
Override padding for links in personal tools in Modern skin

https://gerrit.wikimedia.org/r/237495

Legoktm mentioned this in rECHO5c49d1482b42: Override padding for links in personal tools in Modern skin.Sep 10 2015, 10:56 PM
Diffusion mentioned this in rMEXT6c6fffd113af: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Sep 10 2015, 10:57 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 10 2015, 11:02 PM
Legoktm closed this task as Resolved.Sep 10 2015, 11:49 PM
Legoktm claimed this task.
gerritbot added a comment.Sep 11 2015, 3:29 PM

Change 237672 had a related patch set uploaded (by Legoktm):
Override padding for links in personal tools in Modern skin

https://gerrit.wikimedia.org/r/237672

gerritbot added a comment.Sep 11 2015, 4:15 PM

Change 237672 merged by jenkins-bot:
Override padding for links in personal tools in Modern skin

https://gerrit.wikimedia.org/r/237672

Diffusion mentioned this in rMW2c56fe31677b: Updated mediawiki/core Project: mediawiki/extensions/Echo….Sep 11 2015, 4:15 PM
Legoktm mentioned this in rECHOf6e66b33aaf4: Override padding for links in personal tools in Modern skin.Sep 11 2015, 4:15 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-08_(1.26wmf22).Sep 11 2015, 5:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL