Maniphest T111843

ZeroBanner referencing a VE-MW renamed class - viewPageTarget
Closed, ResolvedPublic0 Estimated Story Points
Actions

Description

includes/ZeroSpecialPage.php:<div dir='$dir' class="zero-init-mw-viewPageTarget-toolbar-actions">$buttons</div>

Details

Related Changes in Gerrit:

	Subject	Repo	Branch	Lines +/-
	Remove redundant class	mediawiki/extensions/ZeroBanner	master	+1 -1

Customize query in gerrit

Event Timeline

Krenair created this task.Sep 8 2015, 6:23 PM

Krenair raised the priority of this task from to Needs Triage.

Krenair updated the task description. (Show Details)

Krenair added projects: VisualEditor-MediaWiki, VisualEditor, ZeroBanner.

Krenair added subscribers: Krenair, Aklapper.

Jdforrester-WMF moved this task from To Triage to Freezer on the VisualEditor board.Sep 8 2015, 7:27 PM

Jdlrobson triaged this task as High priority.Oct 26 2015, 6:57 PM

Jdlrobson subscribed.

MBinder_WMF added a project: Web-Team-Backlog-Archived.May 17 2016, 6:33 PM

Needs confirmation

@Krenair what does this need to be? Or does it need to be removed?

To be honest, I have no idea what the link between ZeroBanner and VisualEditor is. That class can probably just be removed.

Change 307966 had a related patch set uploaded (by Jdlrobson):
Remove redundant class

https://gerrit.wikimedia.org/r/307966

gerritbot added a project: Patch-For-Review.Sep 1 2016, 4:06 PM

Change 307966 merged by Alex Monk:
Remove redundant class

https://gerrit.wikimedia.org/r/307966

• AlexMonk-WMF closed this task as Resolved.Sep 9 2016, 11:17 PM

• AlexMonk-WMF claimed this task.

• AlexMonk-WMF reassigned this task from • AlexMonk-WMF to Jdlrobson.

ReleaseTaggerBot added a project: MW-1.28-release (WMF-deploy-2016-09-13_(1.28.0-wmf.19)).Sep 10 2016, 12:00 AM

Jdforrester-WMF set the point value for this task to 0.Sep 12 2016, 9:13 PM

Jdforrester-WMF moved this task from Freezer to External and Administrivia on the VisualEditor board.

Thanks Alex!

• Phabricator_maintenance moved this task from Needs Prioritization to 2016-17 Q1 on the Web-Team-Backlog-Archived board.Mar 6 2018, 11:51 PM

Restricted Application added a project: User-Ryasmeen. · View Herald TranscriptMar 6 2018, 11:51 PM