Page MenuHomePhabricator

Don't use branches in dependencies of the Maps service
Closed, DeclinedPublic

Description

The list of dependencies in package.json contains some which refer to git branches. This should be avoided and stable pointers should be provided instead. Acceptable options include:

  • use concrete, packaged versions and published on npmjs.com
  • use tags or specific commit SHA1's

Event Timeline

mobrovac created this task.Sep 9 2015, 2:33 PM
mobrovac raised the priority of this task from to Needs Triage.
mobrovac updated the task description. (Show Details)
mobrovac added projects: Maps, Discovery.
mobrovac added subscribers: mobrovac, MaxSem, Yurik.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2015, 2:33 PM
Yurik added a comment.EditedSep 17 2015, 2:42 PM

Oops, answered to the wrong bug here.

I agree in principal, but all refs are parts of the same code tree written by us - so its just like having multiple subdirs. Once we are more stable, we should switch to tagged/versioned approach.

Yurik closed this task as Declined.Nov 7 2015, 7:20 AM
Yurik claimed this task.
Restricted Application added a subscriber: StudiesWorld. · View Herald TranscriptNov 7 2015, 7:20 AM