Page MenuHomePhabricator

Suggestions tab is enabled despite of not set/false in config
Closed, ResolvedPublic1 Story Points

Description

See: http://cx2.wmflabs.org/index.php/Special:ContentTranslation

Config is not set ContentTranslationEnableSuggestions on cx2.

Even if ContentTranslationEnableSuggestions is 'false', I can see Suggestions tab in dashboard.

Details

Related Gerrit Patches:
mediawiki/extensions/ContentTranslation : masterShow suggestions in the dashboard only if enabled
mediawiki/extensions/ContentTranslation : masterShow suggestions in the dashboard only if enabled

Event Timeline

KartikMistry raised the priority of this task from to Needs Triage.
KartikMistry updated the task description. (Show Details)
KartikMistry added subscribers: KartikMistry, santhosh.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2015, 3:39 PM
Amire80 triaged this task as High priority.Sep 9 2015, 4:24 PM
Amire80 set Security to None.

Change 235016 had a related patch set uploaded (by Amire80):
Show suggestions in the dashboard only if enabled

https://gerrit.wikimedia.org/r/235016

https://gerrit.wikimedia.org/r/#/c/235016/ should resolve it, but it will need thorough rebasing, and maybe @Nikerabbit and @santhosh will want to redo it (it's quite simple).

Change 237153 had a related patch set uploaded (by Amire80):
Show suggestions in the dashboard only if enabled

https://gerrit.wikimedia.org/r/237153

OK, I just rebased it myself, not a big deal.

Amire80 claimed this task.Sep 9 2015, 5:52 PM
Amire80 moved this task from Backlog to In Review on the LE-CX6-Sprint 4 board.

Change 235016 abandoned by Amire80:
Show suggestions in the dashboard only if enabled

Reason:
Resubmitted at I02eb423eb92c570d4f38aee8107f10153e1fa7fb

https://gerrit.wikimedia.org/r/235016

Change 237153 merged by jenkins-bot:
Show suggestions in the dashboard only if enabled

https://gerrit.wikimedia.org/r/237153

KartikMistry closed this task as Resolved.Sep 11 2015, 8:08 AM
KartikMistry edited a custom field.
KartikMistry moved this task from In Review to Done on the LE-CX6-Sprint 4 board.