Will eliminate the need for legacy compatibility, and will make it much easier for CentralNotice admins to use banner hiding, which will hopefully decrease the amount of global banner blindness.
This is also an important proof of concept for the mixin architecture.
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| mediawiki/extensions/CentralNotice | master | +199 -4 | Banner diet mixin |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T112923 [EPIC] Banner history post launch | |||
| Resolved | Ejegg | T90919 Show large screen banner and then top screen banner without losing an impression | |||
| Resolved | awight | T112017 Write banner diet campaign mixin |
I tried this for a campaign aa.wikibooks, all looks good to me. Thank you! If everyone's happy, the next step is to enable this on our low-level campaigns.
Q: If I use the same cookie name, will the mixin be compatible with cookies that people already have from the non-mixin code? I can't see any reason why not...
Yes! That was one of my goals in writing the feature, it should be exactly compatible with old cookies, for now. Once everyone has switched to this new system and it doesn't matter, we'll definitely break this compatibility, probably using careful migration deployments so that no group of readers is ever reset or dropped from any campaign's diet feature.