Maniphest T112017

Write banner diet campaign mixin
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Will eliminate the need for legacy compatibility, and will make it much easier for CentralNotice admins to use banner hiding, which will hopefully decrease the amount of global banner blindness.

This is also an important proof of concept for the mixin architecture.

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/extensions/CentralNotice	master	+199 -4	Banner diet mixin

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T112923 [EPIC] Banner history post launch
Resolved	Ejegg	T90919 Show large screen banner and then top screen banner without losing an impression
Resolved	awight	T112017 Write banner diet campaign mixin

Event Timeline

awight created this task.Sep 9 2015, 10:39 PM

awight raised the priority of this task from to Medium.

awight updated the task description. (Show Details)

awight added projects: MediaWiki-extensions-CentralNotice, Fundraising-Backlog, Fundraising Sprint Snoop (Dogg|Lion).

awight added a subscriber: awight.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2015, 10:39 PM

awight claimed this task.Sep 10 2015, 12:03 AM

awight moved this task from Backlog to Doing on the Fundraising Sprint Snoop (Dogg|Lion) board.

awight set Security to None.

awight added a project: Unplanned-Sprint-Work.

Pcoombe added a subscriber: Pcoombe.Sep 10 2015, 2:23 PM

• atgo moved this task from Triage to Closed Sprint Work Q1 1516 on the Fundraising-Backlog board.Sep 14 2015, 5:23 PM

awight edited a custom field.Sep 15 2015, 8:33 PM

• DStrine added a project: Fundraising Sprint Tom Waits.Sep 17 2015, 1:12 AM

• DStrine moved this task from Backlog to Review on the Fundraising Sprint Tom Waits board.Sep 17 2015, 8:11 PM

Change 236229 had a related patch set uploaded (by Awight):
Banner diet mixin

https://gerrit.wikimedia.org/r/236229

gerritbot added a project: Patch-For-Review.Sep 17 2015, 9:01 PM

awight added a parent task: T90919: Show large screen banner and then top screen banner without losing an impression.Sep 30 2015, 10:47 PM

• DStrine added a project: Fundraising Sprint UB40.Sep 30 2015, 10:59 PM

awight moved this task from Backlog to Review on the Fundraising Sprint UB40 board.Sep 30 2015, 11:21 PM

Change 236229 merged by Ejegg:
Banner diet mixin

https://gerrit.wikimedia.org/r/236229

awight mentioned this in rECNOc567c1c04470: Banner diet mixin.Oct 1 2015, 12:25 AM

awight mentioned this in rMEXTd65455029ad7: Updated mediawiki/extensions Project: mediawiki/extensions/CentralNotice….

awight moved this task from Review to Pending Deployment on the Fundraising Sprint UB40 board.Oct 1 2015, 6:58 AM

• DStrine removed a project: Unplanned-Sprint-Work.Oct 1 2015, 5:16 PM

• DStrine moved this task from Closed Sprint Work Q1 1516 to Closed Sprint Work Completed in Q2 1516 on the Fundraising-Backlog board.Oct 5 2015, 5:30 PM

Copying an important comment from T105109:

This should be the default behavior.

awight moved this task from Pending Deployment to Done on the Fundraising Sprint UB40 board.Oct 14 2015, 8:13 PM

@Pcoombe can you try this on a test campaign?

• DStrine added a project: Fundraising Sprint Vengaboys.Oct 14 2015, 11:17 PM

• atgo moved this task from Backlog to Done on the Fundraising Sprint Vengaboys board.Oct 14 2015, 11:19 PM

I tried this for a campaign aa.wikibooks, all looks good to me. Thank you! If everyone's happy, the next step is to enable this on our low-level campaigns.

Q: If I use the same cookie name, will the mixin be compatible with cookies that people already have from the non-mixin code? I can't see any reason why not...

In T112017#1739156, @Pcoombe wrote:

Q: If I use the same cookie name, will the mixin be compatible with cookies that people already have from the non-mixin code? I can't see any reason why not...

Yes! That was one of my goals in writing the feature, it should be exactly compatible with old cookies, for now. Once everyone has switched to this new system and it doesn't matter, we'll definitely break this compatibility, probably using careful migration deployments so that no group of readers is ever reset or dropped from any campaign's diet feature.

awight closed this task as Resolved.Oct 27 2015, 3:57 PM

Liuxinyu970226 removed a subscriber: Liuxinyu970226.Oct 28 2015, 4:57 AM

• DStrine added a project: Fundraising Sprint William Shatner.Oct 28 2015, 10:58 PM

• DStrine removed a project: Fundraising Sprint William Shatner.Oct 28 2015, 11:01 PM

mmodell removed a subscriber: awight.Jun 22 2017, 9:37 PM

• DStrine edited projects, added Fr-tech-archived-from-FY-2015/16; removed Fundraising-Backlog.Jan 11 2018, 9:45 PM