Page MenuHomePhabricator

Board description: VE icons are misplaced
Closed, ResolvedPublic

Description

  1. In betalabs click on Edit description without logging in.
  2. Click on any of misplaced icons - three javascript errors appear:

More screenshots(to check after the fix):

[FLOW] Failed to getInstanceByElement: no $container.length [jQuery.fn.init[1]]mw.loader.implement.mw.flow.debug.FlowComponent.debug @ wAction.open @ load.php?

Uncaught TypeError: flowBoard.getTopicPosters is not a functionmw.loader.implement.mw.flow.ve.ui.MentionInspector.initialize @ VM1555:470OO.ui.Window.setManager @ load.php?debug=false&lang=en&modules=oojs-ui|oojs-ui.styles.icons%2Cicons-editing-

Uncaught TypeError: Cannot read property 'connect' of null

And generally

Uncaught TypeError: Cannot read property 'focus' of undefined ve.ce.Surface.focus @ load.php?
debug=false&lang=en&modules=ext.flow.visualEditor|ext.visualEditor.core%2Cmediawiki%2Cmwco…:353mw.flow.ui.
VisualEditorWidget.focus @ load.php?
debug=false&lang=en&modules=ext.flow|ext.flow.templating%2Cui|ext.thanks.flowthank|oojs-
ui…:170mw.flow.ui.EditorSwitcherWidget.focus
.....

Event Timeline

Etonkovidova raised the priority of this task from to Needs Triage.
Etonkovidova updated the task description. (Show Details)
Etonkovidova added a subscriber: Etonkovidova.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 9 2015, 10:41 PM
Etonkovidova renamed this task from Board description: VE icons are misplaced for non-logged users to Board description: VE icons are misplaced .Sep 9 2015, 10:53 PM
Etonkovidova updated the task description. (Show Details)
Etonkovidova set Security to None.

Change 237291 had a related patch set uploaded (by Catrope):
Follow-up 87faf4b3241: don't break toolbar when setContent() is called

https://gerrit.wikimedia.org/r/237291

Change 237291 merged by jenkins-bot:
Follow-up 87faf4b3241: don't break toolbar when setContent() is called

https://gerrit.wikimedia.org/r/237291

Change 237292 had a related patch set uploaded (by Catrope):
Follow-up 87faf4b3241: don't break toolbar when setContent() is called

https://gerrit.wikimedia.org/r/237292

Change 237292 abandoned by Catrope:
Follow-up 87faf4b3241: don't break toolbar when setContent() is called

Reason:
Never mind, the commit this fixes isn't in wmf22

https://gerrit.wikimedia.org/r/237292

Checked in betalabs.

DannyH closed this task as Resolved.Sep 14 2015, 5:19 PM
DannyH added a subscriber: DannyH.