Maniphest T112057

[WMDE-Fundraising] Add form validation to the sensitive banner
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

See also: https://github.com/wmde/fundraising/issues/664

Event Timeline

WMDE-leszek created this task.Sep 10 2015, 9:01 AM

WMDE-leszek raised the priority of this task from to Needs Triage.

WMDE-leszek updated the task description. (Show Details)

WMDE-leszek added a project: TCB-Team (now WMDE-TechWish).

WMDE-leszek subscribed.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2015, 9:01 AM

WMDE-leszek set Security to None.Sep 10 2015, 9:01 AM

WMDE-leszek edited a custom field.

Tobi_WMDE_SW triaged this task as High priority.Sep 30 2015, 11:53 AM

Tobi_WMDE_SW added a project: TCB-Team-Fundraising-Sprint-2015-09-30.

Tobi_WMDE_SW edited a custom field.

WMDE-leszek claimed this task.Sep 30 2015, 3:53 PM

WMDE-leszek moved this task from Backlog to Doing on the TCB-Team-Fundraising-Sprint-2015-09-30 board.

Tobi_WMDE_SW added a project: TCB-Team-Fundraising-Sprint-2015-10-07.Oct 7 2015, 11:10 AM

Tobi_WMDE_SW moved this task from Backlog to Doing on the TCB-Team-Fundraising-Sprint-2015-10-07 board.

Relevant pull request on github: https://github.com/wmde/fundraising/pull/723

WMDE-leszek moved this task from Doing to Review on the TCB-Team-Fundraising-Sprint-2015-10-07 board.Oct 7 2015, 1:06 PM

WMDE-leszek moved this task from Review to Done on the TCB-Team-Fundraising-Sprint-2015-10-07 board.Oct 8 2015, 2:05 PM

Tobi_WMDE_SW reassigned this task from WMDE-leszek to gabriel-wmde.Oct 14 2015, 11:35 AM

Tobi_WMDE_SW added a project: TCB-Team-Fundraising-Sprint-2015-10-14.

Tobi_WMDE_SW moved this task from Backlog to Doing on the TCB-Team-Fundraising-Sprint-2015-10-14 board.

gabriel-wmde moved this task from Doing to Review on the TCB-Team-Fundraising-Sprint-2015-10-14 board.Oct 15 2015, 11:34 AM

The changed code can be reviewed here: https://github.com/wmde/FundraisingBanners/pull/12

gabriel-wmde moved this task from Review to Doing on the TCB-Team-Fundraising-Sprint-2015-10-14 board.Oct 19 2015, 4:54 PM

The validation of the bank data was missing, so I created a GitHub issue (https://github.com/wmde/FundraisingBanners/issues/15 ) and put the task back into "doing".
Added one commit that tackles the IBAN conversion/BIC insertion, but need to add more code for the different form buttons and the "flow" of the validation.

gabriel-wmde moved this task from Doing to Review on the TCB-Team-Fundraising-Sprint-2015-10-14 board.Oct 20 2015, 1:13 PM

WMDE-Fisch moved this task from Review to Done on the TCB-Team-Fundraising-Sprint-2015-10-14 board.Oct 26 2015, 10:09 AM

Tobi_WMDE_SW closed this task as Resolved.Jan 27 2016, 11:00 AM

Tobi_WMDE_SW moved this task from Incoming to Done on the TCB-Team (now WMDE-TechWish) board.

Tobi_WMDE_SW subscribed.