Page MenuHomePhabricator

Rename the oversight group on WMF projects to the MediaWiki standard (whatever that is)
Open, LowPublic

Description

In T109327#1546253, Krenair wrote:

To do this we have to actually rename the group everywhere

In T109327#1626170, Umherirrender wrote:

Just add the englisch and qqq message key to the WikimediaMessages extension. It has to be oversight, because the user group was not renamed on wmf wikis.

See also

Event Timeline

MarcoAurelio raised the priority of this task from to Needs Triage.
MarcoAurelio updated the task description. (Show Details)

The problem with just renaming groups is that all the old log entries point to the old group. I don't think we want to rewrite them...

Change 237465 had a related patch set uploaded (by MarcoAurelio):
Adding oversight-related messages until group is renamed everywhere

https://gerrit.wikimedia.org/r/237465

Change 237465 merged by jenkins-bot:
Adding oversight-related messages until group is renamed everywhere

https://gerrit.wikimedia.org/r/237465

MarcoAurelio added a subscriber: Umherirrender.

I've removed the WMF-deploy tag since it's part of a related bug, but not this one.

IIRC I was told that this was not going to be easy and required knowledges I don't have to be performed.

There's now a "suppressor" usergroup, with flow-suppress rights to oversight flow posts.

The problem with just renaming groups is that all the old log entries point to the old group. I don't think we want to rewrite them...

So? We can tell people that oversight was renamed to suppress and move on.

I think all this needs is a bit of coordination/announcement and a shell user to run https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/core/+/refs/heads/master/maintenance/migrateUserGroup.php

The motivation for doing this change is to get rid of Technical-Debt, including this stanza in wmf-config:

$wgExtensionFunctions[] = function () {
	global $wgGroupPermissions;
	if ( isset( $wgGroupPermissions['suppress'] ) ) {
		$wgGroupPermissions['oversight'] += $wgGroupPermissions['suppress'];
		unset( $wgGroupPermissions['suppress'] );
	}
};

Hello User-notice people, can we get something like "oversight group will be renamed to suppressor in 14 days, please comment <here> if you have any objections" into the tech news? I'd like to do this...soon, so we can remove some hacks from WMF site config. Thanks!

Hello User-notice people, can we get something like "oversight group will be renamed to suppressor in 14 days, please comment <here> if you have any objections" into the tech news? I'd like to do this...soon, so we can remove some hacks from WMF site config. Thanks!

Can we set WikimediaMessages overrides for those group messages so it still appears to users as "oversight" but internally uses the key "suppressor"?

Hello User-notice people, can we get something like "oversight group will be renamed to suppressor in 14 days, please comment <here> if you have any objections" into the tech news? I'd like to do this...soon, so we can remove some hacks from WMF site config. Thanks!

Can we set WikimediaMessages overrides for those group messages so it still appears to users as "oversight" but internally uses the key "suppressor"?

We should probably alias group-suppress and friends to group-oversight in WikimediaMessages, so it doesn't change the group appearance. It will still change Special:ListUsers/GROUPNAME links, so I think it's fair to announce it anyway :-).

Change 684052 had a related patch set uploaded (by Urbanecm; author: Urbanecm):

[mediawiki/extensions/WikimediaMessages@master] Temporarily alias grouppage-suppress to grouppage-oversight

https://gerrit.wikimedia.org/r/684052

Just noting here that "suppress" is considered a very, very negative word in common English usage. "Oversighter" was bad enough; "Suppressor" is horrendous, and not the kind of user group name that's appropriate for diligent users taking care of some of the nastiest stuff on the projects. I have no idea why someone thought "suppress" was a good name way back in 2009, but it's even worse now in 2021, when we've had multiple opportunities to find a user group name with less authoritarian and negative connotations.

I'm not sure I want to be known as a suppressor.

Just noting here that "suppress" is considered a very, very negative word in common English usage. "Oversighter" was bad enough; "Suppressor" is horrendous, and not the kind of user group name that's appropriate for diligent users taking care of some of the nastiest stuff on the projects. I have no idea why someone thought "suppress" was a good name way back in 2009, but it's even worse now in 2021, when we've had multiple opportunities to find a user group name with less authoritarian and negative connotations.

Thank you for your point of view. I don't agree that it applies to all native English speakers, however.

Jdforrester-WMF renamed this task from Rename the oversight group on WMF projects to Rename the oversight group on WMF projects to the MediaWiki standard (whatever that is).Fri, May 7, 6:47 PM

Just noting here that "suppress" is considered a very, very negative word in common English usage. "Oversighter" was bad enough; "Suppressor" is horrendous, and not the kind of user group name that's appropriate for diligent users taking care of some of the nastiest stuff on the projects. I have no idea why someone thought "suppress" was a good name way back in 2009, but it's even worse now in 2021, when we've had multiple opportunities to find a user group name with less authoritarian and negative connotations.

Thank you for your point of view. I don't agree that it applies to all native English speakers, however.

James, it has been the expressed opinion of the English WIkipedia community, and the oversighter team, since 2009 that the people who carry out this function should never be called "suppressors" nor should that term be used on English Wikipedia due to the negative connotations of the term. The same may not be true of other languages (for all I know, the term being used in other languages may not be nearly as problematic), and it's possible that some people *like* the idea of having user rights that use an explicitly authoritarian name. It's clear that the WMF hasn't cared for 12 years about this, despite it being repeatedly raised by English Wikipedia people.

Call the underlying software what you like, but the term "suppressor" should never appear anywhere on English Wikipedia.

Just noting here that "suppress" is considered a very, very negative word in common English usage. "Oversighter" was bad enough; "Suppressor" is horrendous, and not the kind of user group name that's appropriate for diligent users taking care of some of the nastiest stuff on the projects. I have no idea why someone thought "suppress" was a good name way back in 2009, but it's even worse now in 2021, when we've had multiple opportunities to find a user group name with less authoritarian and negative connotations.

Thank you for your point of view. I don't agree that it applies to all native English speakers, however.

James, it has been the expressed opinion of the English WIkipedia community, and the oversighter team, since 2009 that the people who carry out this function should never be called "suppressors" nor should that term be used on English Wikipedia due to the negative connotations of the term.

Indeed, I was a part of said team at the time. I recall some disquiet about whatever the name should be, but I would not characterise it as a consensus opinion.

However, this discussion is out of scope for this task. I recommend you file a task proposing a different name for it if you think that worthwhile.

However, this discussion is out of scope for this task.

This is exactly what the task is, what to rename the oversight group. Some alternatives: concealers, hiders, obscurers, camouflagers.

Just to clarify, in what areas of the interface would this change be visible? For example, on enwiki the term "oversight" currently appears in Special:UserRights and Special:ListUsers, and the term "Oversighters" appears in Special:ListGroupRights. Would that change to "suppress" and "Suppressors" if this change is deployed? Would it be possible for local communities to overwrite this change with their own custom label if they don't want it?

Edit: After talking to someone on IRC, my understanding is that the end result would be similar to how the software refers to the Administrators group as 'sysop' in parts of the interface (e.g. Special:ListUsers/sysop), but describes it as "administrator" and "Administrators" in other areas of the interface. As long as the interface still reads "oversight" and "Oversighters" just as it works for 'sysop', I don't think this is an objectionable change.

Just to clarify, in what areas of the interface would this change be visible? For example, on enwiki the term "oversight" currently appears in Special:UserRights and Special:ListUsers, and the term "Oversighters" appears in Special:ListGroupRights. Would that change to "suppress" and "Suppressors" if this change is deployed? Would it be possible for local communities to overwrite this change with their own custom label if they don't want it?

Edit: After talking to someone on IRC, my understanding is that the end result would be similar to how the software refers to the Administrators group as 'sysop' in parts of the interface (e.g. Special:ListUsers/sysop), but describes it as "administrator" and "Administrators" in other areas of the interface. As long as the interface still reads "oversight" and "Oversighters" just as it works for 'sysop', I don't think this is an objectionable change.

As of now, MediaWiki uses the word "suppress" pretty much everywhere (even as the group name, for any third-party installation). Wikimedia has a hack in the configuration that mostly renames the group to "oversight" (but sometimes fail, see T275334).

Since the way WMF config changes the group name is really not what it should do, the best fix is to remove the hack and use the suppress group provided by MediaWiki.

This will change the group name everywhere where it is exposed by MediaWiki. Communities can customize that by changing MediaWiki:Group-suppress and MediaWiki:Group-suppress-member. The only thing communities won't be able to customize is the technical group name (that one is usually displayed in URL only).

Does that make sense?

Gotcha, thanks for the clarification. I think the key here is that we can customize the label through the MediaWiki:Group-suppress and MediaWiki:Group-suppress-member pages. On enwiki, I imagine we'll change it to "Oversighters" for MediaWiki:Group-suppress and "oversight" for MediaWiki:Group-suppress-member, so ultimately the impact of this technical change will be imperceptible to most users.