Page MenuHomePhabricator

Skin.php is missing a wfProfileOut call
Closed, ResolvedPublic

Description

Author: Webbed.Pete

Description:
Should be obvious -- an unbalanced set of wfProfileIn but no matching
wfProfileOut :)

Index: Skin.php

  • Skin.php (revision 20208)

+++ Skin.php (working copy)
@@ -269,6 +269,7 @@

		$out->out( $out->reportTime() );

		$out->out( "\n</body></html>" );

+ wfProfileOut( 'Skin::outputPage' );

	}

	static function makeVariablesScript( $data ) {

Version: 1.10.x
Severity: minor

Details

Reference
bz9217

Event Timeline

bzimport raised the priority of this task from to Low.Nov 21 2014, 9:40 PM
bzimport set Reference to bz9217.
bzimport added a subscriber: Unknown Object (MLST).

robchur wrote:

Note that wfProfileIn( METHOD ) and wfProfileOut( METHOD ) are preferred
now, except where the profiling needs to be broken down into independent levels
per function, e.g. "Setup" is profiled in various different segments, as are a
number of the larger functions.

ayg wrote:

Fixed in r20217.