Currently only the area in blue is clickable but the design makes it look like the whole white area is the button, so the whole area should be clickable
Compare with MessageDialog:
Esanders | |
Sep 10 2015, 9:46 PM |
F2607468: Screen Shot 2015-09-15 at 2.16.20 PM.png | |
Sep 15 2015, 9:19 PM |
F2566507: pasted_file | |
Sep 10 2015, 9:46 PM |
F2566510: pasted_file | |
Sep 10 2015, 9:46 PM |
Currently only the area in blue is clickable but the design makes it look like the whole white area is the button, so the whole area should be clickable
Compare with MessageDialog:
Change 237517 had a related patch set uploaded (by Esanders):
Restyle buttons to be fully clickable
Change 237525 had a related patch set uploaded (by Mooeypoo):
Footer buttons should fill their footer containers
Change 237525 abandoned by Mooeypoo:
Footer buttons should fill their footer containers
Reason:
Already covered in I750a18a90c655
The initial design showed them as being a little to the side (because of the icons.)
See T108190: Split notifications into Alerts and Messages
After I converted to framed buttons I had to override the alignment, as framed buttons use text-align:center.
I created that mockup on top of a screenshot of the current status at that time (adding the icon in the header and showing how it fitted with the new badges). It was not intended to describe any change for the rest of the elements.
I agree with @Esanders in making the whole area clickable to match expectations and require less precision to access it. Having the labels centered in that space seems good to me. It can be argued that keeping "All notifications" action aligned with the rest of the elements above it facilitates the scan line, but it also makes the margins to become unbalanced. So overall, I'd expect centered actions to work better.
Change 237628 had a related patch set uploaded (by Esanders):
Let action buttons center align
Checked in betalabs