Page MenuHomePhabricator

Remove SpecialMobileNotifications from MobileFrontend
Closed, ResolvedPublic

Description

It's not obvious at all why this code is here and it seems to serve no purpose right now. Let's remove this and allow the Collaboration Team to improve the code in Echo.
(See also T112191)

Event Timeline

Jdlrobson updated the task description. (Show Details)
Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson moved this task to Needs Analysis on the Reading-Web-Sprint-55-π board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 10 2015, 9:49 PM
Jdlrobson set Security to None.

Change 238083 had a related patch set uploaded (by Bmansurov):
Remove SpecialMobileNotifications

https://gerrit.wikimedia.org/r/238083

bmansurov claimed this task.
phuedx updated the task description. (Show Details)Sep 14 2015, 9:00 AM

I've reviewed 238083 and it LGTM but where did this task come from and who, if anyone, are we supposed to tell that we're doing this – @Jhernandez/@JKatzWMF maybe?

phuedx triaged this task as High priority.Sep 14 2015, 3:31 PM

See "[Web] Closing out sprint π" this was a small task to keep team members busy.
This came out of working with the Echo chaps to move Echo out of MobileFrontend and into their hands so it's one less thing for us to worry about. That team will be worrying about notifications on mobile going forward.

When looking at the frontend code it became apparent that recent changes in the Echo desktop notifications code had broken the mobile experience.

I acknowledge I need to find a better way to move new cards into the sprint so please let me know how you reckon I could do this better... :/

Change 238083 merged by jenkins-bot:
Remove SpecialMobileNotifications

https://gerrit.wikimedia.org/r/238083

Jdlrobson closed this task as Resolved.Sep 14 2015, 10:43 PM

Looks good. Still issues in Echo on mobile but that's covered in T112191 .