It's not obvious at all why this code is here and it seems to serve no purpose right now. Let's remove this and allow the Collaboration Team to improve the code in Echo.
(See also T112191)
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Remove SpecialMobileNotifications | mediawiki/extensions/MobileFrontend | master | +0 -227 |
Related Objects
Related Objects
Event Timeline
Comment Actions
Change 238083 had a related patch set uploaded (by Bmansurov):
Remove SpecialMobileNotifications
Comment Actions
I've reviewed 238083 and it LGTM but where did this task come from and who, if anyone, are we supposed to tell that we're doing this – @Jhernandez/@JKatzWMF maybe?
Comment Actions
See "[Web] Closing out sprint π" this was a small task to keep team members busy.
This came out of working with the Echo chaps to move Echo out of MobileFrontend and into their hands so it's one less thing for us to worry about. That team will be worrying about notifications on mobile going forward.
When looking at the frontend code it became apparent that recent changes in the Echo desktop notifications code had broken the mobile experience.
I acknowledge I need to find a better way to move new cards into the sprint so please let me know how you reckon I could do this better... :/