Page MenuHomePhabricator

The new Echo notification snaps back to English numbers
Closed, ResolvedPublic

Description

Ever since the new Echo notification menus are in use (where you have two separate menus for alerts and messages), when you click on the menu to open it, the number it shows snaps from the localize number to the English number. For instance, on Fa WP if you see "۰" (Persian zero) and click on it, it changes to "0" (English zero). See screenshot.

I suppose it is because JS tries to update the number, but fetches it from a source that is not localized (or fetches it as a numeric value, but forgets to localize it).

Details

Related Gerrit Patches:
mediawiki/extensions/Echo : wmf/1.26wmf22Use localized numbers in the badge
mediawiki/extensions/Echo : masterUse localized numbers in the badge

Event Timeline

Huji created this task.Sep 11 2015, 1:42 AM
Huji raised the priority of this task from to Needs Triage.
Huji updated the task description. (Show Details)
Huji added a project: Notifications.
Huji added a subscriber: Huji.
Restricted Application added a project: Collaboration-Team-Triage. · View Herald TranscriptSep 11 2015, 1:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Huji updated the task description. (Show Details)Sep 11 2015, 1:44 AM
Huji set Security to None.

Change 237572 had a related patch set uploaded (by Legoktm):
Use localized numbers in the badge

https://gerrit.wikimedia.org/r/237572

Change 237572 merged by jenkins-bot:
Use localized numbers in the badge

https://gerrit.wikimedia.org/r/237572

Change 237691 had a related patch set uploaded (by Legoktm):
Use localized numbers in the badge

https://gerrit.wikimedia.org/r/237691

Change 237691 merged by jenkins-bot:
Use localized numbers in the badge

https://gerrit.wikimedia.org/r/237691

Legoktm closed this task as Resolved.Sep 11 2015, 6:15 PM
Legoktm claimed this task.

Checked in Betalabs.