This library would replace leafo/lessphp for LESS compilation in MediaWiki. Its chief advantage is that its parse tree can be cached separately from the final CSS output and reused.
Library URL: https://github.com/oyejorge/less.php
MediaWiki/Core patch: https://gerrit.wikimedia.org/r/#/c/237730/
MediaWiki/Vendor patch: https://gerrit.wikimedia.org/r/#/c/237751/
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | ori | T112035 lessphp performance is catastrophically bad | |||
| Resolved | ori | T486 RfC: Change LESS compilation library | |||
| Resolved | • dpatrick | T112329 Security review for oyejorge/less.php |
Overall, no issues were observed that need be addressed before use.
./bin/lessc
OK - Positive - file operation functions do not allow for interaction with remote files
./lessc.inc.php
OK
./lib/Less/Autoloader.php
OK
./lib/Less/Cache.php
OK - Positive - no possibility for collision with existing files (unless created by another PHP process running less.php and processing the same css files
./lib/Less/Colors.php
OK
./lib/Less/Configurable.php
OK
./lib/Less/Environment.php
OK
./lib/Less/Exception/Chunk.php
OK
./lib/Less/Exception/Compiler.php
OK
./lib/Less/Exception/Parser.php
OK
./lib/Less/Functions.php
OK - Positive - no apparent vector to embed JavaScript in SVG resulting from svggradient()
./lib/Less/Mime.php
OK
./lib/Less/Output/Mapped.php
OK
./lib/Less/Output.php
OK
./lib/Less/Parser.php
OK - Positive - file operation functions do not allow for interaction with remote files
./lib/Less/SourceMap/Base64VLQ.php
OK
./lib/Less/SourceMap/Generator.php
OK
./lib/Less/Tree/Alpha.php
OK
./lib/Less/Tree/Anonymous.php
OK
./lib/Less/Tree/Assignment.php
OK
./lib/Less/Tree/Attribute.php
OK
./lib/Less/Tree/Call.php
OK
./lib/Less/Tree/Color.php
OK
./lib/Less/Tree/Comment.php
OK
./lib/Less/Tree/Condition.php
OK
./lib/Less/Tree/DefaultFunc.php
OK
./lib/Less/Tree/DetachedRuleset.php
OK
./lib/Less/Tree/Dimension.php
OK
./lib/Less/Tree/Directive.php
OK
./lib/Less/Tree/Element.php
OK
./lib/Less/Tree/Expression.php
OK
./lib/Less/Tree/Extend.php
OK
./lib/Less/Tree/Import.php
OK - Positive - no apparent vectors for directory traversal
./lib/Less/Tree/Javascript.php
OK
./lib/Less/Tree/Keyword.php
OK
./lib/Less/Tree/Media.php
OK
./lib/Less/Tree/Mixin/Call.php
OK
./lib/Less/Tree/Mixin/Definition.php
OK
./lib/Less/Tree/NameValue.php
OK
./lib/Less/Tree/Negative.php
OK
./lib/Less/Tree/Operation.php
OK
./lib/Less/Tree/Paren.php
OK
./lib/Less/Tree/Quoted.php
OK
./lib/Less/Tree/Rule.php
OK
./lib/Less/Tree/Ruleset.php
OK
./lib/Less/Tree/RulesetCall.php
OK
./lib/Less/Tree/Selector.php
OK
./lib/Less/Tree/UnicodeDescriptor.php
OK
./lib/Less/Tree/Unit.php
OK
./lib/Less/Tree/UnitConversions.php
OK
./lib/Less/Tree/Url.php
OK
./lib/Less/Tree/Value.php
OK
./lib/Less/Tree/Variable.php
OK
./lib/Less/Tree.php
OK
./lib/Less/Version.php
OK
./lib/Less/Visitor/extendFinder.php
OK
./lib/Less/Visitor/import.php
OK
./lib/Less/Visitor/joinSelector.php
OK
./lib/Less/Visitor/processExtends.php
OK
./lib/Less/Visitor/toCSS.php
OK
./lib/Less/Visitor.php
OK
./lib/Less/VisitorReplacing.php
OK