Page MenuHomePhabricator

Last modified bar should not be inside #bodyContent element
Closed, ResolvedPublic

Description

With the new max-width quick surveys appear under the last modified bar on http://en.m.wikipedia.beta.wmflabs.org/wiki/0.5452742903719006?quicksurvey=true
This is because the last modified bar is incorrectly inside the bodyContent (along with secondary actions). The bodyContent element should only be used to wrap user generated content.

(Surfaced by Quick survey shouldn't appear under last modified bar or discussion link for Minerva skin)

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added subscribers: Aklapper, Jdlrobson.
Jdlrobson updated the task description. (Show Details)Sep 14 2015, 4:22 PM
Jdlrobson set Security to None.
Jdlrobson renamed this task from Quick survey shouldn't appear under last modified bar to Quick survey shouldn't appear under last modified bar or discussion link for Minerva skin.Sep 14 2015, 4:29 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-56-Four Lions board.
Jdlrobson renamed this task from Quick survey shouldn't appear under last modified bar or discussion link for Minerva skin to Last modified bar should not be inside #bodyContent element.Sep 14 2015, 4:32 PM
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a subscriber: rmoen.

Change 238347 had a related patch set uploaded (by Jdlrobson):
Browse tags, page secondary actions and last modified bar outside #bodyContent

https://gerrit.wikimedia.org/r/238347

Change 238347 merged by jenkins-bot:
Browse tags, page secondary actions and last modified bar outside #bodyContent

https://gerrit.wikimedia.org/r/238347

Sorry I missed this during review, but the bar is left aligned on the Main page. Moving to the -1 column.

@bmansurov can you fix/revert - whatever looks least damaging? I'll be able to +2 before bedtime tonight.

Jdlrobson added a subscriber: phuedx.

@bmansurov @phuedx the patch is -1. If you can fix first thing tomorrow that would be great.. I'd rather not do a lightning deploy...

Change 238415 had a related patch set uploaded (by Phuedx):
Revert "Browse tags, page secondary actions and last modified bar outside #bodyContent"

https://gerrit.wikimedia.org/r/238415

Change 238382 had a related patch set uploaded (by Bmansurov):
Center align the last modified bar on the Main page

https://gerrit.wikimedia.org/r/238382

Change 238382 merged by jenkins-bot:
Center align the last modified bar on the Main page

https://gerrit.wikimedia.org/r/238382

Change 238415 abandoned by Phuedx:
Revert "Browse tags, page secondary actions and last modified bar outside #bodyContent"

Reason:
Superseded by I70c9b54.

https://gerrit.wikimedia.org/r/238415

Jdlrobson closed this task as Resolved.Sep 15 2015, 8:53 PM