Page MenuHomePhabricator
Create Task
Maniphest T112366

Ugly replacement of edit => edit source for section edit links on page load
Closed, ResolvedPublic1 Estimated Story Points
Actions

Description

During page load there is ugly noticeable replacement of edit section links from "edit" to "edit source", in namespace where VE isn't enabled.
This should be avoided and replaced before page load in non noticeable way using php hook (e.g onSkinEditSectionLinks)

Details

SubjectRepoBranchLines +/-
Server-side replace Edit=>Edit Source on talk NSmediawiki/extensions/VisualEditormaster+22 -30
Customize query in gerrit

Related Objects

Event Timeline

eranroz created this task.Sep 12 2015, 10:13 AM
eranroz raised the priority of this task from to Needs Triage.
eranroz updated the task description. (Show Details)
eranroz added a project: VisualEditor.
eranroz subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2015, 10:13 AM
eranroz claimed this task.Sep 12 2015, 10:44 AM
eranroz set Security to None.

gerrit bot is too lazy to comment here?
https://gerrit.wikimedia.org/r/#/c/237891/

Aklapper added a project: Patch-For-Review.Sep 12 2015, 1:05 PM
In T112366#1633594, @eranroz wrote:

gerrit bot is too lazy to comment here?

@eranroz: No, Gerritbot just follows the commit message guidelines.

gerritbot subscribed.Sep 12 2015, 1:39 PM

Change 237891 had a related patch set uploaded (by Eranroz):
Avoid flicks in talk pages

https://gerrit.wikimedia.org/r/237891

Jdforrester-WMF subscribed.Sep 14 2015, 10:35 PM

Can you say which wiki/page and with what browser you get a flicker? I don't…

eranroz added a comment.Sep 15 2015, 4:25 AM

What I mean in "flicker" here is a replacement of content during page load that cause change in the size of elements.
This is visible in any talk page (or WP ns), for example, https://en.wikipedia.org/wiki/Talk:WYSIWYG
It can be reproduced in any browser Chrome/Firefox.
The issue is more bold if page load takes longer or artificially if you add "Break on... => "Subtree modifications" on the first .mw-editsection link

Krenair subscribed.Sep 15 2015, 4:29 AM

What is your user interface language?

eranroz added a comment.Sep 15 2015, 4:29 AM

English

Jdforrester-WMF renamed this task from Ugly edit => edit source replacement on page load to Ugly replacement of edit => edit source for section edit links on page load.Sep 15 2015, 6:14 PM
Jdforrester-WMF triaged this task as High priority.
Jdforrester-WMF added a project: VisualEditor-MediaWiki.
Jdforrester-WMF edited a custom field.
Jdforrester-WMF moved this task from To Triage to TR0: Interrupt on the VisualEditor board.
gerritbot added a comment.Sep 17 2015, 1:23 AM

Change 237891 merged by jenkins-bot:
Server-side replace Edit=>Edit Source on talk NS

https://gerrit.wikimedia.org/r/237891

eranroz mentioned this in rEVED051066ead6e8: Server-side replace Edit=>Edit Source on talk NS.Sep 17 2015, 1:23 AM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-22_(1.26wmf24).Sep 17 2015, 2:00 AM
Jdforrester-WMF added a comment.Sep 17 2015, 3:13 AM

Thank you!

Jdforrester-WMF closed this task as Resolved.Sep 17 2015, 3:13 AM
Jdforrester-WMF removed a project: Patch-For-Review.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits