Page MenuHomePhabricator
Create Task
Maniphest T112379

[Regression] Changing preferences while JS is loading will disable the save button after loading is finished
Closed, ResolvedPublic
Actions

Description

In T89457#1538523, @Mormegil wrote:

I went to a foreign wiki I have never visited before and as the first step after my account was autocreated there, I went to [[Special:Preferences]] to change the UI language to something I can cope with. With the JS still loading and the page displayed as one big list instead of the tabbed interface, I changed the language; then the JS finished loading and the display switched to a nice tabbed interface… with the Save button disabled, since I modified the setting prior to the script run. So I needed to change something there and back again in order to be able to save the language setting.

Just saying.

In other words: When the javascript is not fully loaded, but you will change some preferences, the check for the button will not see this changes.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Revert "Disable Preferences save button before setting change"mediawiki/coreREL1_26+0 -6
Revert "Disable Preferences save button before setting change"mediawiki/coremaster+0 -6
Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Sep 12 2015, 2:48 PM
Umherirrender raised the priority of this task from to Needs Triage.
Umherirrender updated the task description. (Show Details)
Umherirrender added projects: MediaWiki-Core-Preferences, JavaScript.
Umherirrender added subscribers: Sn1per, • Jaredzimmerman-WMF, Mormegil and 2 others.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 12 2015, 2:48 PM
Umherirrender mentioned this in T89457: Disable Special:Preferences save button unless settings have been changed.Sep 12 2015, 2:49 PM
Umherirrender added a project: MW-1.26-release.
Umherirrender set Security to None.
Aklapper added a project: Regression.Sep 12 2015, 5:00 PM
saper added a project: Performance Issue.Oct 28 2015, 6:19 PM
saper mentioned this in T115692: Flash of unstyled content (FOUC) on Login page and Preferences (and possibly other highly visible pages?).Oct 28 2015, 6:21 PM
saper subscribed.Oct 28 2015, 6:55 PM

To fix this, I would just propose to remove the JavaScript that disables the "Save" button.

Sn1per added a comment.Oct 28 2015, 9:55 PM

I think removing the functionality is not necessary. Couldn't we simply serialize the saved form data in the PHP stage, rather than in the JavaScript stage, and then check if the current form data is the same as the original data once JS is done loading?

Sn1per claimed this task.Oct 28 2015, 10:13 PM

I implemented the original functionality so I should fix this as well...

saper added a comment.Oct 28 2015, 10:41 PM

Did you say "simply" ? :)

saper added a comment.Oct 28 2015, 10:44 PM

I am a bit annoyed by the disabled save button, but now there is actual reason to remove it. I think the use case "my js is loading slow" is more important then the use case "I left my computer on for 5 hours and I am not sure if I saved my preferences".

I will probably start removing some JS code from the preferences, see comments in https://gerrit.wikimedia.org/r/#/c/247728/

Sn1per removed Sn1per as the assignee of this task.Oct 28 2015, 10:47 PM
In T112379#1763975, @saper wrote:

Did you say "simply" ? :)

meh. "Can't be that hard, right?" *five weeks later* "argh"

In T112379#1763990, @saper wrote:

I am a bit annoyed by the disabled save button, but now there is actual reason to remove it. I think the use case "my js is loading slow" is more important then the use case "I left my computer on for 5 hours and I am not sure if I saved my preferences".

I will probably start removing some JS code from the preferences, see comments in https://gerrit.wikimedia.org/r/#/c/247728/

Well, I suppose that the disappearing notification should handle most cases of forgetting whether or not the preferences are saved.

• demon triaged this task as Medium priority.Nov 2 2015, 7:19 PM
• demon moved this task from Backlog to To be fixed on the MW-1.26-release board.
gerritbot subscribed.Nov 9 2015, 7:28 PM

Change 252021 had a related patch set uploaded (by TheDJ):
Revert "Disable Preferences save button before setting change"

https://gerrit.wikimedia.org/r/252021

gerritbot added a project: Patch-For-Review.Nov 9 2015, 7:28 PM
gerritbot added a comment.Nov 9 2015, 8:05 PM

Change 252021 merged by jenkins-bot:
Revert "Disable Preferences save button before setting change"

https://gerrit.wikimedia.org/r/252021

gerritbot added a comment.Nov 9 2015, 8:16 PM

Change 252029 had a related patch set uploaded (by TheDJ):
Revert "Disable Preferences save button before setting change"

https://gerrit.wikimedia.org/r/252029

TheDJ closed this task as Resolved.Nov 9 2015, 8:34 PM
TheDJ removed a project: Patch-For-Review.
TheDJ moved this task from To be fixed to Done on the MW-1.26-release board.
gerritbot added a comment.Nov 9 2015, 8:45 PM

Change 252029 merged by jenkins-bot:
Revert "Disable Preferences save button before setting change"

https://gerrit.wikimedia.org/r/252029

ReleaseTaggerBot added projects: MW-1.27-release (WMF-deploy-2015-11-10_(1.27.0-wmf.6)), MW-1.27-release-notes.Nov 9 2015, 9:00 PM
Sn1per mentioned this in T119732: Special:Preferences does not display unsaved preferences warning if changes made before JS is done loading.Nov 26 2015, 5:03 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits