Page MenuHomePhabricator
Create Task
Maniphest T112417

UploadWizard throws “Error: Unable to parse title“ when a URL parameter (categories) contains characters not allowed in page titles
Closed, ResolvedPublic
Actions

Description

Steps to reproduce:

Error: https://commons.wikimedia.org/w/load.php?debug=false&lang=fr&modules=jquery%2Cmediawiki&only=scripts&skin=vector&version=T5zOVd1J line 4 > eval at line 21: Error: Unable to parse title

Use case was Wiki Loves Monuments lists like fr:Liste des monuments historiques de Lyon who try to be smart and prefill stuff as much as possible.

Details

SubjectRepoBranchLines +/-
Don't fail horribly when invalid categories are passedmediawiki/extensions/UploadWizardwmf/1.26wmf22+6 -3
Don't fail horribly when invalid categories are passedmediawiki/extensions/UploadWizardmaster+6 -3
Customize query in gerrit

Related Objects

Event Timeline

JeanFred created this task.Sep 12 2015, 10:59 PM
JeanFred raised the priority of this task from to Needs Triage.
JeanFred updated the task description. (Show Details)
JeanFred added a project: UploadWizard.
JeanFred subscribed.
Restricted Application added a project: Multimedia. · View Herald TranscriptSep 12 2015, 10:59 PM
Restricted Application added subscribers: Steinsplitter, Aklapper. · View Herald Transcript
JeanFred updated the task description. (Show Details)Sep 12 2015, 11:00 PM
JeanFred set Security to None.
Restricted Application added a subscriber: Matanya. · View Herald TranscriptSep 12 2015, 11:00 PM
JeanFred added a comment.Sep 12 2015, 11:18 PM

Looks like the culprit (in this case at lease) is the '<' character.

Also occurs when trying to escape characters (using mw.uri.encode)

https://commons.wikimedia.org/wiki/Special:UploadWizard?categories=1%253Earrondissement

zhuyifei1999 subscribed.Sep 13 2015, 12:40 AM
matmarex claimed this task.Sep 13 2015, 6:11 PM
Ash_Crow subscribed.Sep 14 2015, 10:34 AM
• Prtksxna subscribed.Sep 14 2015, 3:38 PM
matmarex renamed this task from UploadWizard throws “Error: Unable to parse title“ when a URL parameter (categories) contains badly escaped characters to UploadWizard throws “Error: Unable to parse title“ when a URL parameter (categories) contains characters not allowed in page titles.Sep 14 2015, 4:31 PM
Jdforrester-WMF triaged this task as High priority.Sep 14 2015, 4:40 PM
Jdforrester-WMF moved this task from Untriaged to Doing on the Multimedia board.
gerritbot subscribed.Sep 14 2015, 7:10 PM

Change 238219 had a related patch set uploaded (by Bartosz Dziewoński):
Don't fail horribly when invalid categories are passed

https://gerrit.wikimedia.org/r/238219

gerritbot added a project: Patch-For-Review.Sep 14 2015, 7:10 PM
gerritbot added a comment.Sep 14 2015, 7:41 PM

Change 238219 merged by jenkins-bot:
Don't fail horribly when invalid categories are passed

https://gerrit.wikimedia.org/r/238219

matmarex mentioned this in rEUWI0cce0f780145: Don't fail horribly when invalid categories are passed.Sep 14 2015, 7:41 PM
Diffusion mentioned this in rMEXT5741e978eb2f: Updated mediawiki/extensions Project: mediawiki/extensions/UploadWizard….Sep 14 2015, 7:41 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 14 2015, 8:00 PM
matmarex closed this task as Resolved.Sep 15 2015, 11:56 AM
JeanFred mentioned this in T112642: UploadWizard throws “Uncaught Error: Unable to parse title ” when a URL parameter (categories) contains characters not allowed in page titles.Sep 15 2015, 12:13 PM
matmarex reopened this task as Open.Sep 15 2015, 12:32 PM
matmarex merged a task: T112642: UploadWizard throws “Uncaught Error: Unable to parse title ” when a URL parameter (categories) contains characters not allowed in page titles.
matmarex subscribed.

Reopening until the fix is deployed on Commons.

By the way, the real issue here is that the parameter value is not valid. 1%3Csup%3Eer%3C%2Fsup%3E+arrondissement is "1<sup>er</sup> arrondissement", which is not a valid category name (or page title). You should fix whatever is generating the problematic URL. My fix makes UploadWizard just ignore the invalid value, rather than break entirely (like you said, the exception causes it to land in a state where you can't do anything).

gerritbot added a comment.Sep 15 2015, 12:33 PM

Change 238421 had a related patch set uploaded (by Bartosz Dziewoński):
Don't fail horribly when invalid categories are passed

https://gerrit.wikimedia.org/r/238421

Jdforrester-WMF moved this task from Doing to Done on the Multimedia board.Sep 15 2015, 3:19 PM
gerritbot added a comment.Sep 15 2015, 3:26 PM

Change 238421 merged by jenkins-bot:
Don't fail horribly when invalid categories are passed

https://gerrit.wikimedia.org/r/238421

matmarex mentioned this in rEUWI584655c00514: Don't fail horribly when invalid categories are passed.Sep 15 2015, 3:27 PM
matmarex mentioned this in rMW1265464e4e7d: Updated mediawiki/core Project: mediawiki/extensions/UploadWizard….
matmarex closed this task as Resolved.Sep 15 2015, 3:43 PM

Deployed now.

ReleaseTaggerBot added a project: WMF-deploy-2015-09-08_(1.26wmf22).Sep 15 2015, 4:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL