Page MenuHomePhabricator
Create Task
Maniphest T112434

PHP alias-related notices are being thrown for social tools specials
Closed, ResolvedPublic
Actions

Description

PHP notices are being thrown, because they haven't been linked to the main alias file in extension.json. They should be.

Details

Show related patches Customize query in gerrit

Related Objects

Event Timeline

Nemo_bis created this task.Sep 13 2015, 7:52 AM
Nemo_bis raised the priority of this task from to Needs Triage.
Nemo_bis updated the task description. (Show Details)
Nemo_bis added a project: PictureGame.
Nemo_bis subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2015, 7:52 AM
SamanthaNguyen moved this task from Backlog to Bugs on the PictureGame board.Sep 1 2016, 2:38 AM
Filip added a project: QuizGame.Jan 21 2017, 7:20 PM
Filip subscribed.

Hmm, looks like its thrown by conflict with extension/mediawiki setting? Also has this problem, cleared LocalSettings.php, and problem disappeared. Need to recreate this again, and find exact extension/mediawiki setting. Appeared in QuizGame.

Restricted Application added a project: Social-Tools. · View Herald TranscriptJan 21 2017, 7:20 PM
SamanthaNguyen renamed this task from PHP Notice: Did not find alias for special page 'PictureGameHome'. Perhaps no aliases are defined for it? to PHP alias-related notices are being thrown for PictureGameHome and QuizGameHome specials.Jan 21 2017, 7:25 PM
SamanthaNguyen updated the task description. (Show Details)
SamanthaNguyen claimed this task.Jan 21 2017, 7:29 PM
SamanthaNguyen added a project: good first task.
SamanthaNguyen subscribed.
This comment was removed by SamanthaNguyen.
Restricted Application added a subscriber: TerraCodes. · View Herald TranscriptJan 21 2017, 7:29 PM
SamanthaNguyen moved this task from Backlog to Bugs on the QuizGame board.Jan 21 2017, 7:30 PM
SamanthaNguyen moved this task from Backlog to Doing on the good first task board.
SamanthaNguyen renamed this task from PHP alias-related notices are being thrown for PictureGameHome and QuizGameHome specials to PHP alias-related notices are being thrown for PictureGame and QuizGame specials.Jan 21 2017, 7:35 PM
SamanthaNguyen updated the task description. (Show Details)
gerritbot subscribed.Jan 21 2017, 7:37 PM

Change 333363 had a related patch set uploaded (by SamanthaNguyen):
Link to main alias file for specials

https://gerrit.wikimedia.org/r/333363

gerritbot added a project: Patch-For-Review.Jan 21 2017, 7:37 PM
Filip added a comment.Jan 21 2017, 8:38 PM

Nevermind. Tested this on my setup, and its unrelated to extensions/settings. Missed $wgShowDebug.

Umherirrender closed this task as Resolved.Jan 21 2017, 10:21 PM
gerritbot added a comment.Jan 21 2017, 10:22 PM

Change 333363 merged by jenkins-bot:
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333363

SamanthaNguyen reopened this task as Open.Jan 21 2017, 10:25 PM
SamanthaNguyen added a subscriber: Umherirrender.

@Umherirrender Thanks for merging it, I need to upload a patch for PictureGame as well however (was waiting for the first patch to be reviewed and merged so I know I could safely do the same thing to the other extension :-)

Filip added a comment.Jan 21 2017, 10:45 PM

Also happen in BlogPage.
PHP Notice: Did not find alias for special page 'CreateBlogPost'. Perhaps no aliases are defined for it?

gerritbot added a comment.Jan 21 2017, 10:45 PM

Change 333457 had a related patch set uploaded (by SamanthaNguyen):
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333457

gerritbot added a comment.Jan 21 2017, 10:48 PM

Change 333458 had a related patch set uploaded (by SamanthaNguyen):
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333458

SamanthaNguyen renamed this task from PHP alias-related notices are being thrown for PictureGame and QuizGame specials to PHP alias-related notices are being thrown for social tools specials.Jan 21 2017, 10:53 PM
SamanthaNguyen added a project: BlogPage.
Umherirrender added a comment.Jan 21 2017, 11:00 PM
In T112434#2958570, @FilipGCI wrote:

Also happen in BlogPage.
PHP Notice: Did not find alias for special page 'CreateBlogPost'. Perhaps no aliases are defined for it?

There are some extensions, which using just "$aliases" in the alias file, not "$specialPageAliases"

ArticleRatings
Challenge
FanBoxes
SpecialNamespaces
SportsTeams
UnusedRedirects
UserExport
Video
gerritbot added a comment.Jan 21 2017, 11:03 PM

Change 333457 merged by jenkins-bot:
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333457

gerritbot added a comment.Jan 21 2017, 11:09 PM

Change 333458 merged by jenkins-bot:
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333458

gerritbot added a comment.Jan 21 2017, 11:14 PM

Change 333459 had a related patch set uploaded (by SamanthaNguyen):
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333459

SamanthaNguyen mentioned this in rEURD5073418d0ba1: Fix typo to prevent PHP alias-notices from being thrown.Jan 21 2017, 11:15 PM
gerritbot added a comment.Jan 21 2017, 11:22 PM

Change 333459 merged by SamanthaNguyen:
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333459

gerritbot added a comment.Jan 21 2017, 11:23 PM

Change 333460 had a related patch set uploaded (by SamanthaNguyen):
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333460

gerritbot added a comment.Jan 21 2017, 11:27 PM

Change 333460 merged by jenkins-bot:
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333460

gerritbot added a comment.Jan 21 2017, 11:29 PM

Change 333461 had a related patch set uploaded (by SamanthaNguyen):
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333461

gerritbot added a comment.Jan 21 2017, 11:33 PM

Change 333461 merged by jenkins-bot:
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333461

gerritbot added a comment.Jan 21 2017, 11:33 PM

Change 333462 had a related patch set uploaded (by SamanthaNguyen):
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333462

gerritbot added a comment.Jan 21 2017, 11:40 PM

Change 333463 had a related patch set uploaded (by SamanthaNguyen):
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333463

gerritbot added a comment.Jan 21 2017, 11:43 PM

Change 333463 merged by jenkins-bot:
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333463

gerritbot added a comment.Jan 21 2017, 11:45 PM

Change 333462 merged by jenkins-bot:
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333462

gerritbot added a comment.Jan 21 2017, 11:46 PM

Change 333464 had a related patch set uploaded (by SamanthaNguyen):
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333464

gerritbot added a comment.Jan 21 2017, 11:48 PM

Change 333464 merged by jenkins-bot:
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333464

gerritbot added a comment.Jan 21 2017, 11:49 PM

Change 333465 had a related patch set uploaded (by SamanthaNguyen):
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333465

gerritbot added a comment.Jan 21 2017, 11:52 PM

Change 333465 merged by jenkins-bot:
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333465

gerritbot added a comment.Jan 21 2017, 11:55 PM

Change 333467 had a related patch set uploaded (by SamanthaNguyen):
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333467

Umherirrender closed this task as Resolved.Jan 21 2017, 11:58 PM
In T112434#2958577, @Umherirrender wrote:
ArticleRatings
Challenge
FanBoxes
SpecialNamespaces
SportsTeams
UnusedRedirects
UserExport
Video

All done, thanks for the patch sets

SamanthaNguyen moved this task from Doing to Done on the good first task board.Jan 22 2017, 12:04 AM
gerritbot added a comment.Jan 22 2017, 12:04 AM

Change 333467 merged by jenkins-bot:
Fix typo to prevent PHP alias-notices from being thrown

https://gerrit.wikimedia.org/r/333467

SamanthaNguyen mentioned this in rEARA4ce1037ca0b0: Fix typo to prevent PHP alias-notices from being thrown.Jan 22 2017, 12:28 AM
Nikerabbit subscribed.Jan 27 2017, 12:16 PM

It's not a typo. The variable name used to be called $aliases but those were all changed about six years ago. Except these extensions.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL