Page MenuHomePhabricator

edits to non-existent section are silently discarded.
Closed, ResolvedPublic

Description

Author: ssanbeg

Description:
This can be shown by creating a template with a few sections, then transcluding
it into a new page (i.e. a new user's talk page)

If these were wiki sections, then if the newbie clicked the edit links on their
page, they would edit the template, which would not be desired. If these are
HTML sections, the links would instead point to the transcluding page;
presumably a bug, but seems like what they'd expect in this case.

But if it's a new page, those sections won't exist, so any edits to them will
just be silently discarded.

Ideally, either these should be appended to the end, or the edit link should
give an error.


Version: unspecified
Severity: normal

Details

Reference
bz9244

Event Timeline

bzimport raised the priority of this task from to High.Nov 21 2014, 9:36 PM
bzimport set Reference to bz9244.
bzimport added a subscriber: Unknown Object (MLST).

ssanbeg wrote:

I've committed a fix in r20459. That adds a new error message, currently only
in English.

ayg wrote:

(In reply to comment #0)

If these were wiki sections, then if the newbie clicked the edit links on their
page, they would edit the template, which would not be desired. If these are
HTML sections, the links would instead point to the transcluding page;
presumably a bug, but seems like what they'd expect in this case.

This should be fixed too (new bug report?). It makes no sense for the edit links to point to a
nonexistent section, generating an error message is just putting a Band-Aid on it.

ayg wrote:

Never mind, that's bug 4034.

ssanbeg wrote:

(In reply to comment #3)

Never mind, that's bug 4034.

Also 9291. Generally, silently discarding edits is bad. If it could only be
triggered from contrived URLs, it may not be worth fixing; but problems with
section edit links pointing to the wrong place recurs too often to be the last
line of defense.

ayg wrote:

*** Bug 8902 has been marked as a duplicate of this bug. ***