Page MenuHomePhabricator

Reproduce size-based JPEG sharpening logic in Thumbor
Closed, ResolvedPublic

Description

This is an alternative approach that would be done instead of T111729: Reproduce size-based JPEG sharpening logic in Varnish

The idea would be to write a plugin/monkey patch for thumbor that would let us hardwire the JPEG sharpening logic. This would take the form of a configuration option that would neuter any sharpen filter parameter passed if the target thumbnail size is less than 15% smaller than the original.

The advantages of doing this in thumbor are to reduce the amount of logic in our caching layer (varnish), that it would still provide expected results in case of cache degradation or when thumbor is directly exposed without a caching layer. Lastly it allows us to generate thumbnails without having to expose the original dimensions in the thumbnail URL.

Details

Event Timeline

Gilles claimed this task.
Gilles raised the priority of this task from to Medium.
Gilles updated the task description. (Show Details)
Gilles added a project: Performance-Team.
Gilles added subscribers: Gilles, Aklapper.

Change 249755 had a related patch set uploaded (by Gilles):
Custom thumbor filter for conditional sharpening

https://gerrit.wikimedia.org/r/249755

Change 251427 had a related patch set uploaded (by Gilles):
Thumbor filter to sharpen conditionally

https://gerrit.wikimedia.org/r/251427

Change 251427 merged by jenkins-bot:
Thumbor filter to sharpen conditionally

https://gerrit.wikimedia.org/r/251427

Change 249755 merged by jenkins-bot:
Custom thumbor filter for conditional sharpening

https://gerrit.wikimedia.org/r/249755