Maniphest T112546

Add sha1 to thumbnail URLs
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• Gilles
	Sep 14 2015, 4:14 PM

Tags

Referenced Files

None

Subscribers

Description

There are already mechanisms purging articles that include images when said images are updated. By adding the sha1 of the original to the thumbnail URL, this ensures that articles always point to the up-to-date version of the thumbnail. Which will then allow us to do T111721: Far-future expires for thumbnails on vagrant

Details

	Project	Branch	Lines +/-	Subject
	mediawiki/core	master	+23 -6	Add option to expose original sha1 in thumb url

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Declined		None	T125920 [EPIC] Future exciting reading web performance endeavours
		Stalled		None	T19577 Thumbnail urls should be versioned and sent with Expires headers
		Resolved		• Gilles	T121388 Service-based thumbnailing re-architecture in production with Thumbor
		Resolved		• Gilles	T111718 Service-based thumbnailing re-architecture on Vagrant
		Resolved		• Gilles	T111721 Far-future expires for thumbnails on vagrant
		Resolved		• Gilles	T112546 Add sha1 to thumbnail URLs

Event Timeline

• Gilles created this task.Sep 14 2015, 4:14 PM

• Gilles claimed this task.

• Gilles raised the priority of this task from to Medium.

• Gilles updated the task description. (Show Details)

• Gilles added a project: Performance-Team.

• Gilles added a parent task: T111721: Far-future expires for thumbnails on vagrant.

• Gilles added subscribers: • Gilles, Aklapper.

Change 238186 had a related patch set uploaded (by Gilles):
Add option to expose original sha1 in thumb url

https://gerrit.wikimedia.org/r/238186

gerritbot added a project: Patch-For-Review.Sep 14 2015, 5:03 PM

• Gilles moved this task from Inbox to Doing (old) on the Performance-Team board.Sep 14 2015, 6:00 PM

• Gilles moved this task from Doing (old) to Backlog: Maintenance on the Performance-Team board.Sep 22 2015, 11:23 AM

Change 238186 merged by jenkins-bot:
Add option to expose original sha1 in thumb url

https://gerrit.wikimedia.org/r/238186

• Gilles mentioned this in rMWab9446c9118d: Add option to expose original sha1 in thumb url.Sep 30 2015, 1:47 AM

ReleaseTaggerBot added projects: MW-1.27-release-notes, MW-1.27-release (WMF-deploy-2015-10-06_(1.27.0-wmf.2)).Sep 30 2015, 2:00 AM

Same as T66214?

Tgr mentioned this in T114098: Remote file thumb generation blocks serving a page.Oct 2 2015, 6:26 AM

This is a modest experiment at this point and is only expected to work on my Thumbor VM setup for now.

• Gilles added a project: Thumbor.Dec 14 2015, 12:00 PM