Page MenuHomePhabricator

`grunt qunit` tool no longer works
Closed, DeclinedPublic

Description

It just times out. Let's update our grunt/Makefile command to use the same as core.

Event Timeline

Jdlrobson raised the priority of this task from to Needs Triage.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added a project: MobileFrontend.
Jdlrobson moved this task to Backlog on the MobileFrontend board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2015, 6:46 PM
Jdlrobson triaged this task as Normal priority.Sep 15 2015, 8:21 PM
TasneemLo renamed this task from `make qunit` tool no longer works to `grunt qunit` tool no longer works.Sep 16 2015, 6:52 AM
TasneemLo set Security to None.
Jdlrobson moved this task from Backlog to Bugs on the MobileFrontend board.Nov 4 2015, 5:04 PM

Rather than using the same as core I propose it is simply removed. Similar to the PHPUnit entry point, extensions are not meant to create their own QUnit context because the needed information exists only in core.

MediaWiki core already has working entry points for phpunit and qunit. I suggest you use those instead. They include any registered extensions' test suites, and the current code in Gather and MobileFrontend already makes use of that, so nothing would change, except the directory from which you run the grunt qunit command.

Purpose is to be able to run unit tests on a pre-commit/pre-git-review hook. If we can remove them and still keep them working on a pre-commit hook that would be acceptable.

Jdlrobson closed this task as Declined.Feb 2 2016, 1:01 AM
Jdlrobson claimed this task.