Page MenuHomePhabricator
Create Task
Maniphest T112571

oojs-ui.styles.textures. oojs-ui.styles.icons, oojs-ui.styles.indicators and oojs-ui.styles loaded in head of mobile despite not being used
Closed, ResolvedPublic
Actions

Description

I'm not sure what brings them in... I'm guessing Echo given the recent rewrite and how they were not there before but really they shouldn't be loaded on every page. Certainly not in the head. They are also causing visual regressions to our overlay close icon.

Details

SubjectRepoBranchLines +/-
Don't load unused Echo JS/CSS on mobilemediawiki/extensions/Echomaster+3 -3
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Sep 14 2015, 7:23 PM
Jdlrobson raised the priority of this task from to Unbreak Now!.
Jdlrobson updated the task description. (Show Details)
Jdlrobson added projects: Performance Issue, MobileFrontend.
Jdlrobson moved this task to Backlog on the MobileFrontend board.
Jdlrobson subscribed.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2015, 7:23 PM
Jdlrobson added a project: Reading-Web-Sprint-56-Four Lions.Sep 14 2015, 7:23 PM
Jdlrobson set Security to None.
Jdlrobson updated the task description. (Show Details)
Jdlrobson mentioned this in T108657: Arrows for close icon and arrow icons are the wrong size MobileFrontend MMV overlay.Sep 14 2015, 7:26 PM
Jdlrobson added a comment.Sep 14 2015, 7:30 PM

These seem to be loaded by OutputPage::enableOOUI
What could be calling that on every single page on English Wikipedia? Any ideas?

Jdlrobson moved this task from Needs Analysis to To Do on the Reading-Web-Sprint-56-Four Lions board.Sep 14 2015, 7:49 PM
Jdlrobson assigned this task to Catrope.Sep 14 2015, 8:43 PM
Jdlrobson added a subscriber: Catrope.

@Catrope said he's looking to fix this for desktop too.

Jdlrobson moved this task from To Do to Doing on the Reading-Web-Sprint-56-Four Lions board.Sep 14 2015, 8:43 PM
gerritbot subscribed.Sep 14 2015, 9:13 PM

Change 238322 had a related patch set uploaded (by Catrope):
Don't load unused Echo JS/CSS on mobile

https://gerrit.wikimedia.org/r/238322

gerritbot added a project: Patch-For-Review.Sep 14 2015, 9:13 PM
RP88 subscribed.Sep 14 2015, 9:41 PM
Jdlrobson moved this task from Doing to Code Review on the Reading-Web-Sprint-56-Four Lions board.Sep 14 2015, 10:40 PM
gerritbot added a comment.Sep 14 2015, 11:16 PM

Change 238322 merged by jenkins-bot:
Don't load unused Echo JS/CSS on mobile

https://gerrit.wikimedia.org/r/238322

Catrope mentioned this in rMEXT54dd6b3a8689: Updated mediawiki/extensions Project: mediawiki/extensions/Echo….Sep 14 2015, 11:16 PM
Catrope mentioned this in rECHOf2ed7a6a5353: Don't load unused Echo JS/CSS on mobile.
Jdlrobson moved this task from Code Review to Ready for Signoff on the Reading-Web-Sprint-56-Four Lions board.Sep 14 2015, 11:17 PM
ReleaseTaggerBot added a project: WMF-deploy-2015-09-15_(1.26wmf23).Sep 15 2015, 12:00 AM
Jdlrobson closed this task as Resolved.Sep 17 2015, 3:38 PM

Thankfully these are no longer showing up when i run mw.loader.inspect() on both enwiki and BC. Thanks for the prompt fix!

Jdlrobson moved this task from Ready for Signoff to Done on the Reading-Web-Sprint-56-Four Lions board.Sep 17 2015, 3:38 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL