Page MenuHomePhabricator

oojs-ui.styles.textures. oojs-ui.styles.icons, oojs-ui.styles.indicators and oojs-ui.styles loaded in head of mobile despite not being used
Closed, ResolvedPublic

Description

I'm not sure what brings them in... I'm guessing Echo given the recent rewrite and how they were not there before but really they shouldn't be loaded on every page. Certainly not in the head. They are also causing visual regressions to our overlay close icon.

Details

Related Gerrit Patches:
mediawiki/extensions/Echo : masterDon't load unused Echo JS/CSS on mobile

Event Timeline

Jdlrobson raised the priority of this task from to Unbreak Now!.
Jdlrobson updated the task description. (Show Details)
Jdlrobson moved this task to Backlog on the MobileFrontend board.
Jdlrobson added a subscriber: Jdlrobson.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 14 2015, 7:23 PM
Jdlrobson set Security to None.
Jdlrobson updated the task description. (Show Details)

These seem to be loaded by OutputPage::enableOOUI
What could be calling that on every single page on English Wikipedia? Any ideas?

Jdlrobson added a subscriber: Catrope.

@Catrope said he's looking to fix this for desktop too.

Change 238322 had a related patch set uploaded (by Catrope):
Don't load unused Echo JS/CSS on mobile

https://gerrit.wikimedia.org/r/238322

RP88 added a subscriber: RP88.Sep 14 2015, 9:41 PM

Change 238322 merged by jenkins-bot:
Don't load unused Echo JS/CSS on mobile

https://gerrit.wikimedia.org/r/238322

Jdlrobson closed this task as Resolved.Sep 17 2015, 3:38 PM

Thankfully these are no longer showing up when i run mw.loader.inspect() on both enwiki and BC. Thanks for the prompt fix!