In http://korma.wmflabs.org/browser/scr-backlog.html "Oldest open Gerrit changesets without code review" includes many "WIP" changesets. This list should get the same filters as "Waiting for review" at http://korma.wmflabs.org/browser/gerrit_review_queue.html for consistency. This way, contributors reviewing these changesets would have a direct impact in the code review queue metrics.
Description
Related Objects
Event Timeline
I don't even find any related code when grep'ing for WIP in random codebases.
@Dicortazar: Where exactly in which codebase is that logic stored?
As mentioned by @Qgil, there's an error with the WIP's. Those were not filtered.
@Aklapper, the filtering code can be found at [1] where the oldest changesets are counted, and in [2], where the most active changesets are calculated.
[1] https://github.com/VizGrimoire/GrimoireLib/blob/master/vizgrimoire/analysis/gerrit_studies.py#L67
[2] https://github.com/VizGrimoire/GrimoireLib/blob/master/vizgrimoire/analysis/gerrit_studies.py#L117 [In this case, those lines and later subqueries]
Data are updated and smoothly running.
My doubt here is why WIPs were there. Some kind of previous decision about having all of them even the WIPs ones?.
In any case, the rest of the filters are correctly applied to both backlogs.
Closing this task.
Thank you!
For the records, that change was: https://github.com/VizGrimoire/GrimoireLib/commit/c917248796b2ac1d1549a7457cff81e0f82075f5