The changes involved in the enhanced silent order post integration maybe probably break the previous API flow. Investigate and fix.
Description
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Case IsHosted parameter for ESOP only. | mediawiki/extensions/DonationInterface | master | +5 -2 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | None | T93293 Fundraise in Japan: July 1-29 | |||
| Declined | • atgo | T93019 Make worldpay forms for Japan | |||
| Resolved | None | T93301 Fundraise in France: October 31 - November 28 | |||
| Declined | None | T91694 Worldpay: donors on Firefox receiving weird SSL error | |||
| Declined | None | T77909 [epic] Make WorldPay more robust | |||
| Resolved | Pcoombe | T86086 Make DI forms visually match what's on donate wiki | |||
| Declined | None | T85583 Fix WP mobile forms | |||
| Declined | None | T89046 Make automated refunds possible in Worldpay | |||
| Declined | None | T1189 Polish : Credit card input form should reflect organization of credit card | |||
| Invalid | None | T86234 Do not log CC exp date | |||
| Declined | None | T109064 Untranslated Credit Card fields (GlobalCollect iframes) | |||
| Restricted Task | |||||
| Declined | None | T112665 Unbreak WMF-hosted Worldpay workflow | |||
| Declined | None | T113787 WPUS: TransDetVer2 audit parsing is broken | |||
| Declined | None | T113789 EXTERNAL Only block French cards on France form. |
Event Timeline
Yep that's the idea. I don't know for a fact that the new stuff breaks the old stuff but I am highly suspicious.
Let's leave some more breadcrumbs here? It might be a while before we get that back on, so it'd be good to have more info.
Since the iframe uses mustache forms and the API uses Rapidhtml there is currently no way to stop the latter from getting both stylesheets and looking bad.
I changed the way the URL we send gets built and added ffname to it so that may cause a problem.
The old config is commented out in form settings so that will definitely break.
Also added a couple things to worldpay.api.php (amount, ffname, redirect url) that are worth checking.
Change 238502 had a related patch set uploaded (by Awight):
Case IsHosted parameter for ESOP only.
adding by Awhight request: Thinking about AMEX processing with merch ID 200639. Trying to think how to send the form country to WP, so they can differentiate processing for France versus other countries. Main thing is to be able to block non-french cards for France, but allow all cards for the rest of the world. example:
France: Amex processing only french issued cards
US: Amex processing cards issued anywhere (not particularly blocked)
they will be able to tell the issuer country from their end, but we need to pass the 'form' country. How can we do that?