Also clone submodules in operations/puppet jobs, otherwise the jobs won't be able to check their content.
E.g. this won't otherwise help: https://gerrit.wikimedia.org/r/#/c/238471/2
Description
Description
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | hashar | T1368 Document RuboCop workflow | |||
| Resolved | zeljkofilipin | T1361 Repositories with Ruby code should be documented and appropriate Jenkins jobs should be running | |||
| Resolved | zeljkofilipin | T102020 Setup rubocop for operations/puppet ruby code lints | |||
| Resolved | hashar | T112670 also clone submodules in operations/puppet jobs |
Event Timeline
Comment Actions
I think this was done some time ago, but I could be wrong. Could you check its validity?
Comment Actions
Status:
| CI job | Submodules |
|---|---|
| operations-puppet-tox-jessie | NO |
| operations-puppet-rake-jessie | YES, recursive |
| operations-puppet-typos | NO |
The operations-puppet-rake-jessie takes care of running puppet-lint / puppet parser validate and has been made to process submodules. A prerequisites was to have each submodules projects in Gerrit to run the same linters as well. That is done now.
operations-puppet-tox-jessie runs a few tests that are solely in puppet.git Not sure it makes sense to add submodules to it.
operations-puppet-typos we can probably trigger it from every operations/puppet/ repositories. Or even better integrate it in rake test.
Comment Actions
Nowadays we have a single job operations-puppet-tests-jessie and it does process submodules, even recursively.