Page MenuHomePhabricator

also clone submodules in operations/puppet jobs
Closed, ResolvedPublic

Description

Also clone submodules in operations/puppet jobs, otherwise the jobs won't be able to check their content.

E.g. this won't otherwise help: https://gerrit.wikimedia.org/r/#/c/238471/2

Event Timeline

JanZerebecki updated the task description. (Show Details)
JanZerebecki raised the priority of this task from to Normal.

I think this was done some time ago, but I could be wrong. Could you check its validity?

Status:

CI jobSubmodules
operations-puppet-tox-jessieNO
operations-puppet-rake-jessieYES, recursive
operations-puppet-typosNO

The operations-puppet-rake-jessie takes care of running puppet-lint / puppet parser validate and has been made to process submodules. A prerequisites was to have each submodules projects in Gerrit to run the same linters as well. That is done now.

operations-puppet-tox-jessie runs a few tests that are solely in puppet.git Not sure it makes sense to add submodules to it.

operations-puppet-typos we can probably trigger it from every operations/puppet/ repositories. Or even better integrate it in rake test.

hashar closed this task as Resolved.Apr 21 2017, 12:32 PM
hashar claimed this task.

Nowadays we have a single job operations-puppet-tests-jessie and it does process submodules, even recursively.